kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix test for stop upgrade

pull/10211/head
Medya Gh 2021-01-21 17:10:37 -08:00
parent de5b9db121
commit 1b93e9df2c
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/integration/version_upgrade_test.go
View File

@ -139,7 +139,26 @@ func TestStoppedBinaryUpgrade(t *testing.T) {
args := append([]string{"start", "-p", profile, "--memory=2200"}, legacyStartArgs()...)
rr := &RunResult{}
r := func() error {
rr, err = Run(t, exec.CommandContext(ctx, tf.Name(), args...))
c := exec.CommandContext(ctx, tf.Name(), args...)
legacyEnv := []string{}
// replace KUBECONFIG env glboally with our own one for this test
// because older minikube than 1.17.0 can not read the new kubeconfigs with "Extenions"
// https://github.com/kubernetes/minikube/issues/10210
for _, e := range os.Environ() {
if !strings.Contains(e, "KUBECONFIG") { // get all global envs except the Kubeconfig which is used by new versions of minikubes
legacyEnv = append(legacyEnv, e)
}
}
// using a fresh kubeconfig for this test
legacyKubeConfig, err := ioutil.TempFile("", "legacy_kubeconfig")
if err != nil {
t.Fatalf("failed to create temp file for legacy kubeconfig %v", err)
}
defer os.Remove(legacyKubeConfig.Name()) // clean up
legacyEnv = append(legacyEnv, fmt.Sprintf("KUBECONFIG=%s", legacyKubeConfig.Name()))
c.Env = legacyEnv
rr, err = Run(t, c)
return err
}