From fd3e0f505a2141ab52864685143b40dcb82a6e72 Mon Sep 17 00:00:00 2001 From: Sharif Elgamal Date: Mon, 30 Mar 2020 15:31:17 -0700 Subject: [PATCH 1/2] clean up minikube start output --- cmd/minikube/cmd/start.go | 1 + pkg/minikube/node/start.go | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 498849f437..780e2ec766 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -371,6 +371,7 @@ func runStart(cmd *cobra.Command, args []string) { ControlPlane: false, KubernetesVersion: cc.KubernetesConfig.KubernetesVersion, } + out.Ln("") // extra newline for clarity on the command line err := node.Add(&cc, n) if err != nil { exit.WithError("adding node", err) diff --git a/pkg/minikube/node/start.go b/pkg/minikube/node/start.go index 44ff9bb1cc..0945a32ddd 100644 --- a/pkg/minikube/node/start.go +++ b/pkg/minikube/node/start.go @@ -66,6 +66,14 @@ const ( // Start spins up a guest and starts the kubernetes node. func Start(cc config.ClusterConfig, n config.Node, existingAddons map[string]bool, apiServer bool) *kubeconfig.Settings { + + cp := "" + if apiServer { + cp = "control plane " + } + + out.T(out.ThumbsUp, "Starting {{.controlPlane}}node {{.name}} in cluster {{.cluster}}", out.V{"controlPlane": cp, "name": n.Name, "cluster": cc.Name}) + var kicGroup errgroup.Group if driver.IsKIC(cc.Driver) { beginDownloadKicArtifacts(&kicGroup) From 2b68cb72d8bea912f4fe725b8fee5c22dc845b37 Mon Sep 17 00:00:00 2001 From: Sharif Elgamal Date: Mon, 30 Mar 2020 15:36:11 -0700 Subject: [PATCH 2/2] glorb --- pkg/minikube/node/start.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/minikube/node/start.go b/pkg/minikube/node/start.go index 0945a32ddd..3b3ee6890f 100644 --- a/pkg/minikube/node/start.go +++ b/pkg/minikube/node/start.go @@ -66,7 +66,6 @@ const ( // Start spins up a guest and starts the kubernetes node. func Start(cc config.ClusterConfig, n config.Node, existingAddons map[string]bool, apiServer bool) *kubeconfig.Settings { - cp := "" if apiServer { cp = "control plane "