kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #8784 from Dean-Coakley/disable-podman2 

Warn user for podman2 version
pull/8835/head
Medya Ghazizadeh 2020-07-24 14:40:18 -07:00 committed by GitHub
parent 8f404164d0 dc566bec0b
commit 1395c8017c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/minikube/registry/drvs/podman/podman.go
View File

@ -34,12 +34,16 @@ import (
"k8s.io/minikube/pkg/minikube/config" "k8s.io/minikube/pkg/minikube/config"
"k8s.io/minikube/pkg/minikube/driver" "k8s.io/minikube/pkg/minikube/driver"
"k8s.io/minikube/pkg/minikube/localpath" "k8s.io/minikube/pkg/minikube/localpath"
"k8s.io/minikube/pkg/minikube/out"
"k8s.io/minikube/pkg/minikube/registry" "k8s.io/minikube/pkg/minikube/registry"
) )
// minReqPodmanVer is required the mininum version of podman to be installed for podman driver. // minReqPodmanVer is required the minimum version of podman to be installed for podman driver.
var minReqPodmanVer = semver.Version{Major: 1, Minor: 7, Patch: 0} var minReqPodmanVer = semver.Version{Major: 1, Minor: 7, Patch: 0}
// podmanVerTwo is required to exit with an error when podman v2 driver is currently installed because it is not supported yet.
var podmanVerTwo = semver.Version{Major: 2, Minor: 0, Patch: 0}
func init() { func init() {
priority := registry.Experimental priority := registry.Experimental
// Staged rollout for default: // Staged rollout for default:
@ -104,7 +108,11 @@ func status() registry.State {
} }
if v.LT(minReqPodmanVer) { if v.LT(minReqPodmanVer) {
glog.Warningf("Warning ! minimum required version for podman is %s. your version is %q. minikube might not work. use at your own risk. To install latest version please see https://podman.io/getting-started/installation.html ", minReqPodmanVer.String(), v.String()) out.WarningT(`The minimum required version for podman is "{{.minVersion}}". your version is "{{.currentVersion}}". minikube might not work. use at your own risk. To install latest version please see https://podman.io/getting-started/installation.html`,
out.V{"minVersion": minReqPodmanVer.String(), "currentVersion": v.String()})
} else if v.GTE(podmanVerTwo) {
out.WarningT(`Using podman 2 is not supported yet. your version is "{{.currentVersion}}". minikube might not work. use at your own risk.`,
out.V{"currentVersion": v.String()})
} }
return registry.State{Installed: true, Healthy: true} return registry.State{Installed: true, Healthy: true}

1
site/content/en/docs/drivers/podman.md
View File

@ -24,6 +24,7 @@ The podman driver is an alternative container runtime to the [Docker]({{< ref "/
## Known Issues ## Known Issues
- Podman driver is not supported on non-amd64 architectures such as arm yet. For non-amd64 archs please use [other drivers]({{< ref "/docs/drivers/_index.md" >}}) - Podman driver is not supported on non-amd64 architectures such as arm yet. For non-amd64 archs please use [other drivers]({{< ref "/docs/drivers/_index.md" >}})
- Podman v2 driver is not supported yet.
- Podman requirements passwordless running of sudo. If you run into an error about sudo, do the following: - Podman requirements passwordless running of sudo. If you run into an error about sudo, do the following:
```shell ```shell