From 444dde078f5dd62b0e4c1a62ea4059ce1f202bac Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Thu, 20 Aug 2020 13:38:45 -0700 Subject: [PATCH] Update NewestVersion to v1.19.0-rc.4 --- pkg/minikube/bootstrapper/images/images.go | 8 ++++++-- pkg/minikube/constants/constants.go | 3 ++- site/content/en/docs/commands/start.md | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/pkg/minikube/bootstrapper/images/images.go b/pkg/minikube/bootstrapper/images/images.go index b066dcc8bb..6cf71f0e07 100644 --- a/pkg/minikube/bootstrapper/images/images.go +++ b/pkg/minikube/bootstrapper/images/images.go @@ -66,8 +66,10 @@ func componentImage(name string, v semver.Version, mirror string) string { func coreDNS(v semver.Version, mirror string) string { // Should match `CoreDNSVersion` in // https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/constants/constants.go - cv := "1.6.7" + cv := "1.7.0" switch v.Minor { + case 18: + cv = "1.6.7" case 17: cv = "1.6.5" case 16: @@ -94,8 +96,10 @@ func etcd(v semver.Version, mirror string) string { // Should match `DefaultEtcdVersion` in: // https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/constants/constants.go - ev := "3.4.3-0" + ev := "3.4.9-1" switch v.Minor { + case 17, 18: + ev = "3.4.3-0" case 16: ev = "3.3.15-0" case 14, 15: diff --git a/pkg/minikube/constants/constants.go b/pkg/minikube/constants/constants.go index 19d2b73ecd..c7104d2673 100644 --- a/pkg/minikube/constants/constants.go +++ b/pkg/minikube/constants/constants.go @@ -29,7 +29,8 @@ const ( // DefaultKubernetesVersion is the default Kubernetes version DefaultKubernetesVersion = "v1.18.3" // NewestKubernetesVersion is the newest Kubernetes version to test against - NewestKubernetesVersion = "v1.18.4-rc.0" + // NOTE: You may need to update coreDNS & etcd versions in pkg/minikube/bootstrapper/images/images.go + NewestKubernetesVersion = "v1.19.0-rc.4" // OldestKubernetesVersion is the oldest Kubernetes version to test against OldestKubernetesVersion = "v1.13.0" // DefaultClusterName is the default nane for the k8s cluster diff --git a/site/content/en/docs/commands/start.md b/site/content/en/docs/commands/start.md index 6fc33a0a18..9b9754d0d4 100644 --- a/site/content/en/docs/commands/start.md +++ b/site/content/en/docs/commands/start.md @@ -68,7 +68,7 @@ minikube start [flags] --interactive Allow user prompts for more information (default true) --iso-url strings Locations to fetch the minikube ISO from. (default [https://storage.googleapis.com/minikube/iso/minikube-v1.12.2.iso,https://github.com/kubernetes/minikube/releases/download/v1.12.2/minikube-v1.12.2.iso,https://kubernetes.oss-cn-hangzhou.aliyuncs.com/minikube/iso/minikube-v1.12.2.iso]) --keep-context This will keep the existing kubectl context and will create a minikube context. - --kubernetes-version string The Kubernetes version that the minikube VM will use (ex: v1.2.3, 'stable' for v1.18.3, 'latest' for v1.18.4-rc.0). Defaults to 'stable'. + --kubernetes-version string The Kubernetes version that the minikube VM will use (ex: v1.2.3, 'stable' for v1.18.3, 'latest' for v1.19.0-rc.4). Defaults to 'stable'. --kvm-gpu Enable experimental NVIDIA GPU support in minikube --kvm-hidden Hide the hypervisor signature from the guest in minikube (kvm2 driver only) --kvm-network string The KVM network name. (kvm2 driver only) (default "default")