From 0ea84f9d14c91e21e8dd2e8f226ce8045c44efef Mon Sep 17 00:00:00 2001 From: Medya Ghazizadeh Date: Fri, 24 Apr 2020 14:25:15 -0700 Subject: [PATCH] Revert "docker-env: fall back to bash if can not detect shell." --- cmd/minikube/cmd/docker-env.go | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/cmd/minikube/cmd/docker-env.go b/cmd/minikube/cmd/docker-env.go index 9d8914a2d7..c4432c6b58 100644 --- a/cmd/minikube/cmd/docker-env.go +++ b/cmd/minikube/cmd/docker-env.go @@ -27,8 +27,6 @@ import ( "strconv" "strings" - lib_shell "github.com/docker/machine/libmachine/shell" - "github.com/golang/glog" "github.com/spf13/cobra" "k8s.io/minikube/pkg/drivers/kic/oci" "k8s.io/minikube/pkg/minikube/command" @@ -170,14 +168,7 @@ var dockerEnvCmd = &cobra.Command{ if ec.Shell == "" { ec.Shell, err = shell.Detect() if err != nil { - // if we can't detect it could be bash. for example github actions - if err == lib_shell.ErrUnknownShell { - ec.Shell = "bash" - glog.Warningf("couldn't detect shell type, will default to bash: %v", err) - } else { - exit.WithError("Error detecting shell", err) - } - + exit.WithError("Error detecting shell", err) } }