From d519e7246e3ed84cb9b512f16b04a465cdc455c2 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Mon, 15 Mar 2021 17:05:46 -0700 Subject: [PATCH 1/5] lint --- pkg/minikube/reason/known_issues.go | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/pkg/minikube/reason/known_issues.go b/pkg/minikube/reason/known_issues.go index 47d73e8a31..055af4c0cc 100644 --- a/pkg/minikube/reason/known_issues.go +++ b/pkg/minikube/reason/known_issues.go @@ -221,6 +221,16 @@ var providerIssues = []match{ }, // Docker environment + { + Kind: Kind{ + ID: "PR_DOCKER_IP_CONFLICT", + ExitCode: ExProviderError, + Advice: "Run: 'minikube delete --all' to clean up all the abandoned networks.", + Issues: []int{9605}, + }, + Regexp: re(`cannot find cgroup mount destination: unknown`), + GOOS: []string{"linux"}, + }, { Kind: Kind{ ID: "PR_DOCKER_CGROUP_MOUNT", @@ -364,6 +374,18 @@ var providerIssues = []match{ // KVM hypervisor { + Kind: Kind{ + ID: "PR_KVM_CAPABILITIES", + ExitCode: ExProviderUnavailable, + Advice: "Your host does not support KVM virtualization. Ensure that qemu-kvm is installed, and run 'virt-host-validate' to debug the problem", + URL: "http://mikko.repolainen.fi/documents/virtualization-with-kvm", + Issues: []int{2991}, + }, + Regexp: re(`invalid argument: could not find capabilities for domaintype=kvm`), + GOOS: []string{"linux"}, + }, + { + Kind: Kind{ ID: "PR_KVM_USER_PERMISSION", ExitCode: ExProviderPermission, From f17f8a458f87362f889088d30975b43e2546df2d Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Mon, 15 Mar 2021 17:06:20 -0700 Subject: [PATCH 2/5] go mod tidy --- go.sum | 2 -- 1 file changed, 2 deletions(-) diff --git a/go.sum b/go.sum index 7df609fc38..cebbb83142 100644 --- a/go.sum +++ b/go.sum @@ -734,7 +734,6 @@ github.com/opencontainers/runtime-spec v1.0.0/go.mod h1:jwyrGlmzljRJv/Fgzds9SsS/ github.com/opencontainers/selinux v1.3.1-0.20190929122143-5215b1806f52/go.mod h1:+BLncwf63G4dgOzykXAxcmnFlUaOlkDdmw/CqsW6pjs= github.com/otiai10/copy v1.0.2 h1:DDNipYy6RkIkjMwy+AWzgKiNTyj2RUI9yEMeETEpVyc= github.com/otiai10/copy v1.0.2/go.mod h1:c7RpqBkwMom4bYTSkLSym4VSJz/XtncWRAj/J4PEIMY= -github.com/otiai10/curr v0.0.0-20150429015615-9b4961190c95 h1:+OLn68pqasWca0z5ryit9KGfp3sUsW4Lqg32iRMJyzs= github.com/otiai10/curr v0.0.0-20150429015615-9b4961190c95/go.mod h1:9qAhocn7zKJG+0mI8eUu6xqkFDYS2kb2saOteoSB3cE= github.com/otiai10/mint v1.3.0 h1:Ady6MKVezQwHBkGzLFbrsywyp09Ah7rkmfjV3Bcr5uc= github.com/otiai10/mint v1.3.0/go.mod h1:F5AjcsTsWUqX+Na9fpHb52P8pcRX2CI6A3ctIT91xUo= @@ -1010,7 +1009,6 @@ golang.org/x/mod v0.1.1-0.20191107180719-034126e5016b/go.mod h1:QqPTAvyqsEbceGzB golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= golang.org/x/mod v0.4.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= -golang.org/x/mod v0.4.1 h1:Kvvh58BN8Y9/lBi7hTekvtMpm07eUZ0ck5pRHpsMWrY= golang.org/x/mod v0.4.1/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= golang.org/x/mod v0.4.2 h1:Gz96sIWK3OalVv/I/qNygP42zyoKp3xptRVCWRFEBvo= golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= From bec4d61eac35960d7dfcb2da9ba37e1dafbff9f1 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Mon, 15 Mar 2021 17:27:30 -0700 Subject: [PATCH 3/5] KVM code error --- pkg/minikube/reason/known_issues.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/minikube/reason/known_issues.go b/pkg/minikube/reason/known_issues.go index 055af4c0cc..4df6e90b9f 100644 --- a/pkg/minikube/reason/known_issues.go +++ b/pkg/minikube/reason/known_issues.go @@ -375,13 +375,13 @@ var providerIssues = []match{ // KVM hypervisor { Kind: Kind{ - ID: "PR_KVM_CAPABILITIES", - ExitCode: ExProviderUnavailable, - Advice: "Your host does not support KVM virtualization. Ensure that qemu-kvm is installed, and run 'virt-host-validate' to debug the problem", - URL: "http://mikko.repolainen.fi/documents/virtualization-with-kvm", - Issues: []int{2991}, + ID: "PR_KVM_MISSING_NETWORK", + ExitCode: ExProviderError, + Advice: "Validate your KVM networks. Run: virt-host-validate and Run:", + Issues: []int{9009}, + URL: "https://minikube.sigs.k8s.io/docs/drivers/kvm2/", }, - Regexp: re(`invalid argument: could not find capabilities for domaintype=kvm`), + Regexp: re(`virError(Code=43, Domain=19, Message='Network not found: no network with matching name`), GOOS: []string{"linux"}, }, { From 4bfacd7a646152574d3f133b1cedd6cb0a97e453 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Mon, 15 Mar 2021 17:29:24 -0700 Subject: [PATCH 4/5] KVM code error --- pkg/minikube/reason/known_issues.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/minikube/reason/known_issues.go b/pkg/minikube/reason/known_issues.go index 4df6e90b9f..421ab003dd 100644 --- a/pkg/minikube/reason/known_issues.go +++ b/pkg/minikube/reason/known_issues.go @@ -377,7 +377,7 @@ var providerIssues = []match{ Kind: Kind{ ID: "PR_KVM_MISSING_NETWORK", ExitCode: ExProviderError, - Advice: "Validate your KVM networks. Run: virt-host-validate and Run:", + Advice: "Validate your KVM networks. Run: virt-host-validate and then virsh net-list --all", Issues: []int{9009}, URL: "https://minikube.sigs.k8s.io/docs/drivers/kvm2/", }, From a8c50926d0d2e43be47462527b6670979490c60c Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Mon, 15 Mar 2021 17:44:49 -0700 Subject: [PATCH 5/5] fix regex --- pkg/minikube/reason/known_issues.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/minikube/reason/known_issues.go b/pkg/minikube/reason/known_issues.go index 421ab003dd..8e4c7e1593 100644 --- a/pkg/minikube/reason/known_issues.go +++ b/pkg/minikube/reason/known_issues.go @@ -381,7 +381,7 @@ var providerIssues = []match{ Issues: []int{9009}, URL: "https://minikube.sigs.k8s.io/docs/drivers/kvm2/", }, - Regexp: re(`virError(Code=43, Domain=19, Message='Network not found: no network with matching name`), + Regexp: re(`Message='Network not found: no network with matching name`), GOOS: []string{"linux"}, }, {