kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

addressed more comments

pull/11746/head
Steven Powell 2021-06-23 10:42:39 -07:00
parent 39208c56c4
commit 0a5aadf502
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
hack/update/golang_version/.update_golang_version.go.swp
View File

Binary file not shown.

13
pkg/minikube/translate/translate_test.go
View File

@ -18,8 +18,8 @@ package translate
import (
"encoding/json"
"fmt"
"os"
"path/filepath"
"regexp"
"sort"
"testing"
@ -104,11 +104,14 @@ func TestT(t *testing.T) {
}
func TestTranslationFilesValid(t *testing.T) {
languages := []string{"de", "es", "fr", "ja", "ko", "pl", "zh-CN"}
languageFiles, err := filepath.Glob("../../../translations/*.json")
if err != nil {
t.Fatalf("failed to get translation files: %v", err)
}
re := regexp.MustCompile(`{{\..+?}}`)
for _, lang := range languages {
for _, filename := range languageFiles {
lang := filepath.Base(filename)
t.Run(lang, func(t *testing.T) {
filename := fmt.Sprintf("../../../translations/%s.json", lang)
contents, err := os.ReadFile(filename)
if err != nil {
t.Fatalf("unable to read file %s: %v", filename, err)
@ -150,7 +153,7 @@ func TestTranslationFilesValid(t *testing.T) {
for i, keyVar := range keyVariables {
// check if translated string has same variable
if keyVar != valueVariables[i] {
t.Errorf("line %q has mismatching variables; original string variables: %s do not match translated variables: %s", k, keyVariables, valueVariables)
t.Errorf("line %q: %q has mismatching variables\noriginal string variables: %s do not match translated variables: %s", k, v, keyVariables, valueVariables)
break
}
}