From 095fd2a526ebe102dc95aaee7ecd7f7a3d962b19 Mon Sep 17 00:00:00 2001 From: Priya Wadhwa Date: Fri, 6 Mar 2020 17:36:58 -0800 Subject: [PATCH] review comments --- pkg/minikube/node/config.go | 2 +- pkg/minikube/node/start.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/node/config.go b/pkg/minikube/node/config.go index 0031b4948b..14ad22ae8f 100644 --- a/pkg/minikube/node/config.go +++ b/pkg/minikube/node/config.go @@ -68,7 +68,7 @@ func configureRuntimes(runner cruntime.CommandRunner, drvName string, k8s config } if !driver.IsKIC(drvName) { if err := cr.Preload(k8s.KubernetesVersion); err != nil { - glog.Infof("Failed to preload container runtime %s: %v, falling back to caching images", cr.Name(), err) + glog.Errorf("Failed to preload container runtime %s: %v, falling back to caching images", cr.Name(), err) if err := machine.CacheImagesForBootstrapper(k8s.ImageRepository, k8s.KubernetesVersion, viper.GetString(cmdcfg.Bootstrapper)); err != nil { exit.WithError("Failed to cache images", err) } diff --git a/pkg/minikube/node/start.go b/pkg/minikube/node/start.go index 045471cacf..8dfbde6643 100644 --- a/pkg/minikube/node/start.go +++ b/pkg/minikube/node/start.go @@ -59,6 +59,7 @@ func Start(mc config.ClusterConfig, n config.Node, primary bool, existingAddons mRunner, preExists, machineAPI, host := startMachine(&mc, &n) defer machineAPI.Close() + // wait for preloaded tarball to finish downloading before configuring runtimes waitCacheRequiredImages(&cacheGroup) // configure the runtime (docker, containerd, crio)