From d9bd59da8b341fab97815f744c2b3e7a3b3ce307 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 11:00:07 -0700 Subject: [PATCH 01/17] Work on improvements to release docs. --- docs/contributors/releasing_minikube.md | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 513d4f59b7..ec9268a88e 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -8,21 +8,19 @@ Collect the release notes, and edit them as necessary: hack/release_notes.sh ``` -Then merge into the CHANGELOG.md file. See [this PR](https://github.com/kubernetes/minikube/pull/164) for an example. +Merge output into CHANGELOG.md file. See [this PR](https://github.com/kubernetes/minikube/pull/164) for an example. -## Build and Release a New ISO +## Build a new ISO + + * Visit http:///job/ISO/build + * Ensure that you are logged in (top right) + * For ISO_VERSION, fill in the intended release version + * For ISO_BUCKET, use minikube/iso + * Click "Build" + * Wait ~45 minutes + +## Update ISO path -This step isn't always required. Check if there were changes in the deploy directory. -If you do this, bump the ISO URL to point to the new ISO, and send a PR. -To do this, build the new ISO by running: -```shell -deploy/iso/build.sh -``` -This will generate a new ISO at 'deploy/iso/minikube.iso'. Then upload the ISO and shasum using the following command: -```shell -gsutil cp deploy/iso/minikube.iso gs://minikube/minikube-.iso -gsutil cp deploy/iso/minikube.iso.sha256 gs://minikube/minikube-.iso.sha256 -``` ## Run integration tests From b77b55a78e30ba454443c0ee72d48e72a6b171c2 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 11:16:13 -0700 Subject: [PATCH 02/17] First step in reworking release docs. --- docs/contributors/releasing_minikube.md | 51 +++++++++++++------------ 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index ec9268a88e..d08a4ea463 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -1,42 +1,36 @@ # Steps to Release Minikube -## Create a Release Notes PR - -Collect the release notes, and edit them as necessary: - -```shell -hack/release_notes.sh -``` - -Merge output into CHANGELOG.md file. See [this PR](https://github.com/kubernetes/minikube/pull/164) for an example. - ## Build a new ISO - * Visit http:///job/ISO/build + * http://go/minikube:build-iso * Ensure that you are logged in (top right) - * For ISO_VERSION, fill in the intended release version - * For ISO_BUCKET, use minikube/iso - * Click "Build" + * For `ISO_VERSION`, use the intended release version + * For `ISO_BUCKET`, use `minikube/iso` + * Click *Build* * Wait ~45 minutes -## Update ISO path +## Update Makefile +Once the ISO has built, update the Makefile: -## Run integration tests +```shell +VERSION_MINOR +ISO_VERSION +``` + +## Run Local Integration Test + +Run the integration tests, making sure that all tests pass: -Run this command: ```shell make integration ``` -Investigate and fix any failures. -## Bump the version in the Makefile and Update Docs to reflect this +## Submit PR to update the Makefile -See [this PR](https://github.com/kubernetes/minikube/pull/165) for an example. +Pay careful attention to integration test failures from Jenkins. -##Send an initial commit with the Makefile change: - -Send a PR for the Makefile change and wait until it is merged. Once the commit is merged, continue. +If there are test flakes, open or find the appropriate Issue, and add a PR comment with links to the appropriate issues. ## Build the Release @@ -46,7 +40,16 @@ Run this command: BUILD_IN_DOCKER=y make cross checksum ``` -## Add the version to the releases.json file +## Submit PR to update Release Notes and `releases.json` + +Then Collect the release notes, and edit them as necessary: + +```shell +hack/release_notes.sh +``` + +Merge output into CHANGELOG.md file. See [this PR](https://github.com/kubernetes/minikube/pull/3175) for an example. + Add an entry **to the top** of deploy/minikube/releases.json with the **version** and **checksums**. Send a PR. From 0991957030ed700f73aa286c13d8014d4ea279db Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 11:45:18 -0700 Subject: [PATCH 03/17] Bump makefile to v0.30.0 --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index bdc6023f72..6b3e6486bb 100755 --- a/Makefile +++ b/Makefile @@ -14,7 +14,7 @@ # Bump these on release VERSION_MAJOR ?= 0 -VERSION_MINOR ?= 29 +VERSION_MINOR ?= 30 VERSION_BUILD ?= 0 VERSION ?= v$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD) DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR)-$(VERSION_BUILD) @@ -26,7 +26,7 @@ HYPERKIT_BUILD_IMAGE ?= karalabe/xgo-1.10.x BUILD_IMAGE ?= k8s.gcr.io/kube-cross:v1.10.1-1 ISO_BUILD_IMAGE ?= $(REGISTRY)/buildroot-image -ISO_VERSION ?= v0.29.0 +ISO_VERSION ?= v0.30.0 ISO_BUCKET ?= minikube/iso MINIKUBE_VERSION ?= $(ISO_VERSION) From e439f6ee54246a377ddf3e1b38d7d556a95d46ef Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 11:55:16 -0700 Subject: [PATCH 04/17] More updates --- docs/contributors/releasing_minikube.md | 64 +++++++++++-------------- 1 file changed, 27 insertions(+), 37 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index d08a4ea463..bd72a1d6dd 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -4,42 +4,50 @@ * http://go/minikube:build-iso * Ensure that you are logged in (top right) - * For `ISO_VERSION`, use the intended release version - * For `ISO_BUCKET`, use `minikube/iso` + * For `ISO_VERSION`, type in the intended release version + * For `ISO_BUCKET`, type in `minikube/iso` * Click *Build* - * Wait ~45 minutes + +The build will take roughly 50 minutes. ## Update Makefile -Once the ISO has built, update the Makefile: +Edit the minikube `Makefile`, updating the version number values at the top: -```shell -VERSION_MINOR -ISO_VERSION -``` +* `VERSION_MINOR` +* `ISO_VERSION` ## Run Local Integration Test -Run the integration tests, making sure that all tests pass: +With the updated Makefile, run the integration tests and ensure that all tests pass: ```shell -make integration +env TEST_ARGS="-minikube-start-args=--vm-driver=kvm2" make integration ``` -## Submit PR to update the Makefile +## Ad-Hoc testing of other platforms -Pay careful attention to integration test failures from Jenkins. - -If there are test flakes, open or find the appropriate Issue, and add a PR comment with links to the appropriate issues. - -## Build the Release - -Run this command: +If there are supported platforms which do not have functioning Jenkins workers (Windows), you may use the following to build a sanity check: ```shell BUILD_IN_DOCKER=y make cross checksum ``` +## Send out Makefile PR + +This will update users of HEAD to the new ISO. + +Please pay attention to test failures, as this is our integration test across platforms. If there are known acceptable failures, please add a PR comment linking to the appropriate issue. + +## Build the Release + +This step publishes a new binary release, but only for people who know where to find it: + + * http://go/minikube:build-release + * Ensure that you are logged in (top right) + * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 + * Click *Build* + ## Submit PR to update Release Notes and `releases.json` Then Collect the release notes, and edit them as necessary: @@ -50,27 +58,9 @@ hack/release_notes.sh Merge output into CHANGELOG.md file. See [this PR](https://github.com/kubernetes/minikube/pull/3175) for an example. +Then update `deploy/minikube/releases.json`, which controls auto-update notifications. Add an entry **to the top** of deploy/minikube/releases.json with the **version** and **checksums**. -Send a PR. -This file controls the auto update notifications in minikube. -Only add entries to this file that should be released to all users (no pre-release, alpha or beta releases). -The file must be uploaded to GCS before notifications will go out. That step comes at the end. - -The schema for this file can be found in deploy/minikube/schema.json. - -An automated test to verify the schema runs in Travis before each submit. - -## Upload to GCS: - -```shell -gsutil cp out/minikube-linux-amd64 gs://minikube/releases/$RELEASE/ -gsutil cp out/minikube-linux-amd64.sha256 gs://minikube/releases/$RELEASE/ -gsutil cp out/minikube-darwin-amd64 gs://minikube/releases/$RELEASE/ -gsutil cp out/minikube-darwin-amd64.sha256 gs://minikube/releases/$RELEASE/ -gsutil cp out/minikube-windows-amd64.exe gs://minikube/releases/$RELEASE/ -gsutil cp out/minikube-windows-amd64.exe.sha256 gs://minikube/releases/$RELEASE/ -``` ## Tag the Release From b6021f64186f10c4ac5785c3a1480d553a26f32a Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 13:15:08 -0700 Subject: [PATCH 05/17] Reword more. --- docs/contributors/releasing_minikube.md | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index bd72a1d6dd..1f43a5fba7 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -48,19 +48,17 @@ This step publishes a new binary release, but only for people who know where to * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 * Click *Build* -## Submit PR to update Release Notes and `releases.json` +## Update Release Notes and `releases.json` -Then Collect the release notes, and edit them as necessary: +Add the checksums for the release to the top of `deploy/minikube/releases.json`. This file is used for auto-update notifications. The notifications are not activated until this file is copied to GCS. + +Then run the following script to update the release notes: ```shell hack/release_notes.sh ``` -Merge output into CHANGELOG.md file. See [this PR](https://github.com/kubernetes/minikube/pull/3175) for an example. - -Then update `deploy/minikube/releases.json`, which controls auto-update notifications. - -Add an entry **to the top** of deploy/minikube/releases.json with the **version** and **checksums**. +Merge the output into CHANGELOG.md. See [PR#3175](https://github.com/kubernetes/minikube/pull/3175) as an example. Then get the PR submitted. ## Tag the Release @@ -68,13 +66,14 @@ Run a command like this to tag it locally: `git tag -a v0.2.0 -m "0.2.0 Release" And run a command like this to push the tag: `git push upstream v0.2.0`. + ## Create a Release in Github Create a new release based on your tag, like [this one](https://github.com/kubernetes/minikube/releases/tag/v0.2.0). Upload the files, and calculated checksums. -## Upload the releases.json file to GCS +## Upload releases.json to GCS This step makes the new release trigger update notifications in old versions of Minikube. Use this command from a clean git repo: @@ -107,11 +106,11 @@ The repository is tracked in this repo under a submodule `installers/linux/arch_ To actually update the package, you should bump the version and update the sha512 checksum. You should also run `makepkg --printsrcinfo > .SRCINFO` to update the srcinfo file. You can edit this manually if you don't have `makepkg` on your machine. -## Release Verification +## Verification After you've finished the release, run this command from the release commit to verify the release was done correctly: `make check-release`. ## Update kubernetes.io docs -If there are major changes, please send a PR upstream for this file https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/getting-started-guides/minikube.md in order to keep the getting started guide up to date. +If there are major changes, please send a PR to update the official setup guide: [Running Kubernetes Locally via Minikube](https://kubernetes.io/docs/setup/minikube/) From cc0a97f304a7e5b7601162426c3a1b5e0a97dd92 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 14:30:48 -0700 Subject: [PATCH 06/17] Building a release requires tags to be built --- docs/contributors/releasing_minikube.md | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 1f43a5fba7..13623e989d 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -39,15 +39,6 @@ This will update users of HEAD to the new ISO. Please pay attention to test failures, as this is our integration test across platforms. If there are known acceptable failures, please add a PR comment linking to the appropriate issue. -## Build the Release - -This step publishes a new binary release, but only for people who know where to find it: - - * http://go/minikube:build-release - * Ensure that you are logged in (top right) - * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 - * Click *Build* - ## Update Release Notes and `releases.json` Add the checksums for the release to the top of `deploy/minikube/releases.json`. This file is used for auto-update notifications. The notifications are not activated until this file is copied to GCS. @@ -66,6 +57,14 @@ Run a command like this to tag it locally: `git tag -a v0.2.0 -m "0.2.0 Release" And run a command like this to push the tag: `git push upstream v0.2.0`. +## Build the Release + +This step uses the git tag to publish new binaries, but only for people who know where to find them: + + * http://go/minikube:build-release + * Ensure that you are logged in (top right) + * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 + * Click *Build* ## Create a Release in Github From fe15132c31254819a5f02df62c4f553975b5196f Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 14:46:20 -0700 Subject: [PATCH 07/17] Improve build release doc --- docs/contributors/releasing_minikube.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 13623e989d..c7c88165bd 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -59,10 +59,11 @@ And run a command like this to push the tag: `git push upstream v0.2.0`. ## Build the Release -This step uses the git tag to publish new binaries, but only for people who know where to find them: +This step uses the git tag to publish new binaries to GCS: * http://go/minikube:build-release * Ensure that you are logged in (top right) + * `VERSION_MAJOR`, `VERSION_MINOR`, and `VERSION_BUILD` should reflect the values in your Makefile * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 * Click *Build* From 317f69a964be1c3cb30828e5688b14fda1747c4f Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 14:53:50 -0700 Subject: [PATCH 08/17] Split releases.json work, since it cannot be done until after the Jenkins workflow --- docs/contributors/releasing_minikube.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index c7c88165bd..182aa7ba06 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -39,9 +39,7 @@ This will update users of HEAD to the new ISO. Please pay attention to test failures, as this is our integration test across platforms. If there are known acceptable failures, please add a PR comment linking to the appropriate issue. -## Update Release Notes and `releases.json` - -Add the checksums for the release to the top of `deploy/minikube/releases.json`. This file is used for auto-update notifications. The notifications are not activated until this file is copied to GCS. +## Update Release Notes Then run the following script to update the release notes: @@ -73,6 +71,10 @@ Create a new release based on your tag, like [this one](https://github.com/kuber Upload the files, and calculated checksums. +## Update releases.json + +Send out a PR to update the release checksums at the top of `deploy/minikube/releases.json`. This file is used for auto-update notifications, but is not active until releases.json is copied to GCS. + ## Upload releases.json to GCS This step makes the new release trigger update notifications in old versions of Minikube. From 9a1b79fdc4e2d99d858cb4b4709e1f31c29370ba Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 16:15:04 -0700 Subject: [PATCH 09/17] Reflect the reality of the Jenkins release builder. --- docs/contributors/releasing_minikube.md | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 182aa7ba06..cf0e3728fb 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -51,13 +51,13 @@ Merge the output into CHANGELOG.md. See [PR#3175](https://github.com/kubernetes/ ## Tag the Release -Run a command like this to tag it locally: `git tag -a v0.2.0 -m "0.2.0 Release"`. +Run a command like this to tag it locally: `git tag -a v -m " Release"`. -And run a command like this to push the tag: `git push upstream v0.2.0`. +And run a command like this to push the tag: `git push upstream v`. ## Build the Release -This step uses the git tag to publish new binaries to GCS: +This step uses the git tag to publish new binaries to GCS and create a github release: * http://go/minikube:build-release * Ensure that you are logged in (top right) @@ -65,15 +65,11 @@ This step uses the git tag to publish new binaries to GCS: * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 * Click *Build* -## Create a Release in Github - -Create a new release based on your tag, like [this one](https://github.com/kubernetes/minikube/releases/tag/v0.2.0). - -Upload the files, and calculated checksums. - ## Update releases.json -Send out a PR to update the release checksums at the top of `deploy/minikube/releases.json`. This file is used for auto-update notifications, but is not active until releases.json is copied to GCS. +minikube-bot will send out a PR to update the release checksums at the top of `deploy/minikube/releases.json`. Make sure it is submitted, or hack one together yourself. + +This file is used for auto-update notifications, but is not active until releases.json is copied to GCS. ## Upload releases.json to GCS From 10fa467dbeb91a412e7c254718074f9f7a382045 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 16:42:05 -0700 Subject: [PATCH 10/17] Quote gs URL so that the wildcard works properly. --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index cf0e3728fb..ad13a45237 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -83,7 +83,7 @@ gsutil cp deploy/minikube/releases.json gs://minikube/releases.json ## Mark the release as `latest` in GCS: ```shell -gsutil cp -r gs://minikube/releases/$RELEASE/* gs://minikube/releases/latest/ +gsutil cp -r 'gs://minikube/releases/$RELEASE/*' gs://minikube/releases/latest/ ``` ## Package managers which include minikube From b50ef4c02731cd5411ba9bbc5c2e5390235275f5 Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:28:34 -0700 Subject: [PATCH 11/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index ad13a45237..e02460fd60 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -2,6 +2,9 @@ ## Build a new ISO +You only need to build the minikube ISO when the there are changes in the `deploy/iso` folder. +Note: you can build the ISO using the `hack/jenkins/build_iso.sh` script locally. + * http://go/minikube:build-iso * Ensure that you are logged in (top right) * For `ISO_VERSION`, type in the intended release version From 558b2d8755b11c74eb4f9585f6df28029415ab3e Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:28:37 -0700 Subject: [PATCH 12/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index e02460fd60..3146f3bbb8 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -5,7 +5,7 @@ You only need to build the minikube ISO when the there are changes in the `deploy/iso` folder. Note: you can build the ISO using the `hack/jenkins/build_iso.sh` script locally. - * http://go/minikube:build-iso + * navigate to the minikube ISO jenkins job * Ensure that you are logged in (top right) * For `ISO_VERSION`, type in the intended release version * For `ISO_BUCKET`, type in `minikube/iso` From fddd58bb715b45aa5149231d8531a2a9ab84c79f Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:31:26 -0700 Subject: [PATCH 13/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 3146f3bbb8..fa7d4e35d4 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -18,7 +18,7 @@ The build will take roughly 50 minutes. Edit the minikube `Makefile`, updating the version number values at the top: * `VERSION_MINOR` -* `ISO_VERSION` +* `ISO_VERSION` (only update this if there is a new ISO release) ## Run Local Integration Test From 33f70268ecd08afaae538badd3cfa8b9d44aa98f Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:31:32 -0700 Subject: [PATCH 14/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index fa7d4e35d4..7f6876bad2 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -7,7 +7,7 @@ Note: you can build the ISO using the `hack/jenkins/build_iso.sh` script locally * navigate to the minikube ISO jenkins job * Ensure that you are logged in (top right) - * For `ISO_VERSION`, type in the intended release version + * For `ISO_VERSION`, type in the intended release version (same as the minikube binary's version) * For `ISO_BUCKET`, type in `minikube/iso` * Click *Build* From 3014102a6304e4c42a57cda12be91370d7ac9eff Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:31:35 -0700 Subject: [PATCH 15/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 7f6876bad2..7844c28b73 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -44,7 +44,7 @@ Please pay attention to test failures, as this is our integration test across pl ## Update Release Notes -Then run the following script to update the release notes: +Run the following script to update the release notes: ```shell hack/release_notes.sh From 474421fd219beabd8b75777d0d14f9bd8875063e Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:31:38 -0700 Subject: [PATCH 16/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 7844c28b73..3bf89b92b5 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -17,7 +17,7 @@ The build will take roughly 50 minutes. Edit the minikube `Makefile`, updating the version number values at the top: -* `VERSION_MINOR` +* `VERSION_MINOR` (and `VERSION_MAJOR`, `VERSION_BUILD` as necessary) * `ISO_VERSION` (only update this if there is a new ISO release) ## Run Local Integration Test From 1b798c0fd3a33e78b3c4008b96d351991257800e Mon Sep 17 00:00:00 2001 From: Balint Pato Date: Fri, 19 Oct 2018 15:31:52 -0700 Subject: [PATCH 17/17] Update docs/contributors/releasing_minikube.md Co-Authored-By: tstromberg --- docs/contributors/releasing_minikube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 3bf89b92b5..e155c3616a 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -62,7 +62,7 @@ And run a command like this to push the tag: `git push upstream v`. This step uses the git tag to publish new binaries to GCS and create a github release: - * http://go/minikube:build-release + * navigate to the minikube "Release" jenkins job * Ensure that you are logged in (top right) * `VERSION_MAJOR`, `VERSION_MINOR`, and `VERSION_BUILD` should reflect the values in your Makefile * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256