From 010b29c178fcfc2f8550122870494be839c71323 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 13 Aug 2019 14:24:30 -0700 Subject: [PATCH] lint and TODO comment --- cmd/minikube/cmd/config/profile.go | 7 +++++-- pkg/minikube/config/profile.go | 7 ++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cmd/minikube/cmd/config/profile.go b/cmd/minikube/cmd/config/profile.go index aa94c33612..b6518aa15f 100644 --- a/cmd/minikube/cmd/config/profile.go +++ b/cmd/minikube/cmd/config/profile.go @@ -21,7 +21,7 @@ import ( "github.com/spf13/cobra" "github.com/spf13/viper" - pkgConfig "k8s.io/minikube/pkg/minikube/config" //TODO:Medyagh + pkgConfig "k8s.io/minikube/pkg/minikube/config" //TODO:Medyagh have consistent naming everywhere pk_config "k8s.io/minikube/pkg/minikube/constants" "k8s.io/minikube/pkg/minikube/exit" "k8s.io/minikube/pkg/minikube/kubeconfig" @@ -50,7 +50,10 @@ var ProfileCmd = &cobra.Command{ } if !pkgConfig.ProfileExists(profile) { - pkgConfig.CreateEmptyProfile(profile) + err := pkgConfig.CreateEmptyProfile(profile) + if err != nil { + exit.WithError("Creating a new profile failed", err) + } out.SuccessT("Created a new profile : {{.profile_name}}", out.V{"profile_name": profile}) } diff --git a/pkg/minikube/config/profile.go b/pkg/minikube/config/profile.go index 58ddb1a053..3e21d3c8cd 100644 --- a/pkg/minikube/config/profile.go +++ b/pkg/minikube/config/profile.go @@ -44,12 +44,9 @@ func ProfileExists(name string, miniHome ...string) bool { miniPath = miniHome[0] } - p := profileFilePath(name, miniHome...) + p := profileFilePath(name, miniPath) _, err := os.Stat(p) - if err != nil { - return false - } - return true + return err != nil } // CreateProfile creates an empty profile stores in $MINIKUBE_HOME/profiles//config.json