Merge pull request #3589 from tstromberg/travis-broked

minor de-linting of cmd/config: run gofmt, goimports, pre-allocate fields slice
pull/3488/head
Thomas Strömberg 2019-01-25 11:07:36 -08:00 committed by GitHub
commit 00be38dadc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 11 deletions

View File

@ -20,9 +20,8 @@ import (
"encoding/json"
"fmt"
"io"
"strings"
"os"
"strings"
"github.com/spf13/cobra"
"k8s.io/minikube/pkg/minikube/config"
@ -222,8 +221,8 @@ var settings = []Setting{
name: "logviewer",
set: SetBool,
validations: []setFn{IsValidAddon},
},
{
},
{
name: "gvisor",
set: SetBool,
validations: []setFn{IsValidAddon, IsContainerdRuntime},
@ -259,7 +258,7 @@ Configurable fields: ` + "\n\n" + configurableFields(),
}
func configurableFields() string {
var fields []string
fields := []string{}
for _, s := range settings {
fields = append(fields, " * "+s.name)
}

View File

@ -23,7 +23,6 @@ import (
"github.com/golang/glog"
"github.com/spf13/cobra"
"k8s.io/minikube/pkg/minikube/config"
"k8s.io/minikube/pkg/minikube/constants"
)

View File

@ -21,9 +21,8 @@ import (
"io/ioutil"
"os"
"k8s.io/minikube/pkg/minikube/service"
"github.com/spf13/cobra"
"k8s.io/minikube/pkg/minikube/service"
)
var addonsConfigureCmd = &cobra.Command{

View File

@ -17,13 +17,12 @@ limitations under the License.
package config
import (
"errors"
"fmt"
"os"
"k8s.io/minikube/pkg/minikube/config"
"errors"
"github.com/spf13/cobra"
"k8s.io/minikube/pkg/minikube/config"
)
var configGetCmd = &cobra.Command{