keel-hq
/
keel
mirror of https://github.com/keel-hq/keel/tree/master/chart/keel
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #83 from rusenask/develop 

Develop
pull/92/head 0.4.5
Karolis Rusenas 2017-08-06 11:20:00 +01:00 committed by GitHub
parent 01d005e01a e87a6e1b0c
commit d940252794
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/version/version.go
View File

@ -110,7 +110,7 @@ func NewAvailable(current string, tags []string) (newVersion string, newAvailabl
sort.Sort(sort.Reverse(semver.Collection(vs))) sort.Sort(sort.Reverse(semver.Collection(vs)))
if currentVersion.LessThan(vs[0]) { if currentVersion.LessThan(vs[0]) {
return vs[0].String(), true, nil return vs[0].Original(), true, nil
} }
return "", false, nil return "", false, nil
} }

16
util/version/version_test.go
View File

@ -272,7 +272,21 @@ func TestNewAvailable(t *testing.T) {
{ {
name: "staging", name: "staging",
args: args{current: "1.1.1", tags: []string{"v1.2.1-staging.1"}}, args: args{current: "1.1.1", tags: []string{"v1.2.1-staging.1"}},
wantNewVersion: "1.2.1-staging.1", wantNewVersion: "v1.2.1-staging.1",
wantNewAvailable: true,
wantErr: false,
},
{
name: "without patch version",
args: args{current: "8.1", tags: []string{"8.1", "8.2", "8.3"}},
wantNewVersion: "8.3",
wantNewAvailable: true,
wantErr: false,
},
{
name: "only major version",
args: args{current: "8.1.1", tags: []string{"8", "9", "10"}},
wantNewVersion: "10",
wantNewAvailable: true, wantNewAvailable: true,
wantErr: false, wantErr: false,
}, },