credentialshelper: fix ecr 401 caused by secret credentialhelper, and mute error log in searching credentialhelpers

pull/241/head
kagahehk01 2018-07-24 00:42:02 +08:00
parent 1bc01a0578
commit bfdee651c8
2 changed files with 7 additions and 2 deletions

View File

@ -86,13 +86,15 @@ func GetCredentials(image *types.TrackedImage) (creds *types.Credentials) {
"helper": name,
"error": err,
"tracked_image": image,
}).Error("extension.credentialshelper: credentials not found")
}).Debug("extension.credentialshelper: credentials not found")
}
} else {
return creds
}
}
}
log.WithFields(log.Fields{
"tracked_image": image,
}).Error("extension.credentialshelper: credentials helper not found")
return creds
}

View File

@ -76,6 +76,9 @@ func (g *DefaultGetter) Get(image *types.TrackedImage) (*types.Credentials, erro
// populating secrets
image.Secrets = secrets
}
if len(image.Secrets) == 0 {
return nil, ErrSecretsNotSpecified
}
return g.getCredentialsFromSecret(image)
}