keel-hq
/
keel
mirror of https://github.com/keel-hq/keel/tree/master/chart/keel
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

naming changed

pull/7/head
Karolis Rusenas 2017-06-14 19:40:55 +01:00
parent 1ca5749ca7
commit 6e07105e56
2 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
trigger/pubsub/pubsub.go
View File

@ -15,7 +15,8 @@ import (
log "github.com/Sirupsen/logrus"
)
type Subscriber struct {
// PubsubSubscriber is Google Cloud pubsub based subscriber
type PubsubSubscriber struct {
providers map[string]provider.Provider
project string
@ -30,18 +31,20 @@ type pubsubImplementer interface {
Receive(ctx context.Context, f func(context.Context, *Message)) error
}
// Opts - subscriber options
type Opts struct {
ProjectID string
Providers map[string]provider.Provider
}
func NewSubscriber(opts *Opts) (*Subscriber, error) {
// NewPubsubSubscriber - create new pubsub subscriber
func NewPubsubSubscriber(opts *Opts) (*PubsubSubscriber, error) {
client, err := pubsub.NewClient(context.Background(), opts.ProjectID)
if err != nil {
return nil, err
}
return &Subscriber{
return &PubsubSubscriber{
project: opts.ProjectID,
providers: opts.Providers,
client: client,
@ -54,7 +57,7 @@ type Message struct {
Tag string `json:"tag,omitempty"`
}
func (s *Subscriber) ensureTopic(ctx context.Context, id string) error {
func (s *PubsubSubscriber) ensureTopic(ctx context.Context, id string) error {
topic := s.client.Topic(id)
exists, err := topic.Exists(ctx)
if err != nil {
@ -72,7 +75,7 @@ func (s *Subscriber) ensureTopic(ctx context.Context, id string) error {
return err
}
func (s *Subscriber) ensureSubscription(ctx context.Context, subscriptionID, topicID string) error {
func (s *PubsubSubscriber) ensureSubscription(ctx context.Context, subscriptionID, topicID string) error {
sub := s.client.Subscription(subscriptionID)
exists, err := sub.Exists(ctx)
if err != nil {
@ -93,8 +96,8 @@ func (s *Subscriber) ensureSubscription(ctx context.Context, subscriptionID, top
return fmt.Errorf("failed to create subscription %s, error: %s", subscriptionID, err)
}
// Subscribe - initiate subscriber
func (s *Subscriber) Subscribe(ctx context.Context, topic, subscription string) error {
// Subscribe - initiate PubsubSubscriber
func (s *PubsubSubscriber) Subscribe(ctx context.Context, topic, subscription string) error {
// ensuring that topic exists
err := s.ensureTopic(ctx, topic)
if err != nil {
@ -110,7 +113,7 @@ func (s *Subscriber) Subscribe(ctx context.Context, topic, subscription string)
log.WithFields(log.Fields{
"topic": topic,
"subscription": subscription,
}).Info("trigger.pubsub: subscribing for events...")
}).Info("trigger.pubsub: subscribing for events...")
err = sub.Receive(ctx, s.callback)
if err != nil {
log.WithFields(log.Fields{
@ -120,7 +123,7 @@ func (s *Subscriber) Subscribe(ctx context.Context, topic, subscription string)
return err
}
func (s *Subscriber) callback(ctx context.Context, msg *pubsub.Message) {
func (s *PubsubSubscriber) callback(ctx context.Context, msg *pubsub.Message) {
// disable ack, useful for testing
if !s.disableAck {
defer msg.Ack()

2
trigger/pubsub/pubsub_test.go
View File

@ -35,7 +35,7 @@ func fakeDoneFunc(id string, done bool) {
func TestCallback(t *testing.T) {
fp := &fakeProvider{}
sub := &Subscriber{disableAck: true, providers: map[string]provider.Provider{
sub := &PubsubSubscriber{disableAck: true, providers: map[string]provider.Provider{
fp.GetName(): fp,
}}