From 5ce7c99a2ebf1c85d8e0a33cf9bf00771e333a5d Mon Sep 17 00:00:00 2001 From: Michael Mccallum Date: Sun, 6 Aug 2017 12:14:58 +1200 Subject: [PATCH 1/2] Use the original tag not the semverified For examle trailing 0 are added on parse and used for validation but may be missing from the tag. --- util/version/version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/version/version.go b/util/version/version.go index db0773c9..24cf49c5 100644 --- a/util/version/version.go +++ b/util/version/version.go @@ -110,7 +110,7 @@ func NewAvailable(current string, tags []string) (newVersion string, newAvailabl sort.Sort(sort.Reverse(semver.Collection(vs))) if currentVersion.LessThan(vs[0]) { - return vs[0].String(), true, nil + return vs[0].Original(), true, nil } return "", false, nil } From 0eeca779f7cf8d6db943ee25f2d323420298edec Mon Sep 17 00:00:00 2001 From: Michael Mccallum Date: Sun, 6 Aug 2017 12:21:09 +1200 Subject: [PATCH 2/2] verify that 2 point semver versions use original value --- util/version/version_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/util/version/version_test.go b/util/version/version_test.go index 082d273f..8735b5c3 100644 --- a/util/version/version_test.go +++ b/util/version/version_test.go @@ -276,6 +276,13 @@ func TestNewAvailable(t *testing.T) { wantNewAvailable: true, wantErr: false, }, + { + name: "simple semver", + args: args{current: "8.1", tags: []string{"8.1", "8.2", "8.3"}}, + wantNewVersion: "8.3", + wantNewAvailable: true, + wantErr: false, + }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) {