moving approval registration into the cmd main func

approvals/approvals.go

@@ -13,7 +13,6 @@ import (
 	"github.com/keel-hq/keel/pkg/store"
 	"github.com/keel-hq/keel/types"
 
-	"github.com/prometheus/client_golang/prometheus"
 	log "github.com/sirupsen/logrus"
 )
 
@@ -91,15 +90,6 @@ func New(opts *Opts) *DefaultManager {
 		subMu:      &sync.RWMutex{},
 	}
 
-	prom_pending := prometheus.NewGaugeFunc(prometheus.GaugeOpts{
-		Name: "keel_pending_approvals",
-		Help: "number of the pending approvals",
-	}, func() float64 {
-		approvals, _ := man.List()
-		return float64(len(approvals))
-	})
-	prometheus.MustRegister(prom_pending)
-
 	return man
 }
 

cmd/keel/main.go

@@ -9,6 +9,7 @@ import (
 
 	"context"
 
+	"github.com/prometheus/client_golang/prometheus"
 	netContext "golang.org/x/net/context"
 	kingpin "gopkg.in/alecthomas/kingpin.v2"
 	kube "k8s.io/client-go/kubernetes"
@@ -198,6 +199,18 @@ func main() {
 		Store: sqlStore,
 	})
 
+	pendindApprovalsCounter := prometheus.NewGaugeFunc(prometheus.GaugeOpts{
+		Name: "pending_approvals",
+		Help: "Number of the pending approvals",
+	}, func() float64 {
+		approvals, err := approvalsManager.List()
+		if err != nil {
+			return float64(len(approvals))
+		}
+		return 0
+	})
+	prometheus.MustRegister(pendindApprovalsCounter)
+
 	go approvalsManager.StartExpiryService(ctx)
 
 	// setting up providers