k8s provider unversioned updates

pull/99/head
Karolis Rusenas 2017-09-12 15:54:59 +03:00
parent a621e7dd20
commit 0b17c18e2b
1 changed files with 56 additions and 60 deletions

View File

@ -4,6 +4,8 @@ import (
"reflect"
"testing"
"github.com/rusenask/keel/approvals"
"github.com/rusenask/keel/extension/notification"
"github.com/rusenask/keel/types"
meta_v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/pkg/api/v1"
@ -12,9 +14,11 @@ import (
func TestProvider_checkUnversionedDeployment(t *testing.T) {
type fields struct {
implementer Implementer
events chan *types.Event
stop chan struct{}
implementer Implementer
sender notification.Sender
approvalManager approvals.Manager
events chan *types.Event
stop chan struct{}
}
type args struct {
policy types.PolicyType
@ -25,7 +29,7 @@ func TestProvider_checkUnversionedDeployment(t *testing.T) {
name string
fields fields
args args
wantUpdated v1beta1.Deployment
wantUpdatePlan *UpdatePlan
wantShouldUpdateDeployment bool
wantErr bool
}{
@ -56,26 +60,30 @@ func TestProvider_checkUnversionedDeployment(t *testing.T) {
v1beta1.DeploymentStatus{},
},
},
wantUpdated: v1beta1.Deployment{
meta_v1.TypeMeta{},
meta_v1.ObjectMeta{
Name: "dep-1",
Namespace: "xxxx",
Annotations: map[string]string{forceUpdateImageAnnotation: "gcr.io/v2-namespace/hello-world:latest"},
Labels: map[string]string{types.KeelPolicyLabel: "all"},
},
v1beta1.DeploymentSpec{
Template: v1.PodTemplateSpec{
Spec: v1.PodSpec{
Containers: []v1.Container{
v1.Container{
Image: "gcr.io/v2-namespace/hello-world:latest",
wantUpdatePlan: &UpdatePlan{
Deployment: v1beta1.Deployment{
meta_v1.TypeMeta{},
meta_v1.ObjectMeta{
Name: "dep-1",
Namespace: "xxxx",
Annotations: map[string]string{forceUpdateImageAnnotation: "gcr.io/v2-namespace/hello-world:latest"},
Labels: map[string]string{types.KeelPolicyLabel: "all"},
},
v1beta1.DeploymentSpec{
Template: v1.PodTemplateSpec{
Spec: v1.PodSpec{
Containers: []v1.Container{
v1.Container{
Image: "gcr.io/v2-namespace/hello-world:latest",
},
},
},
},
},
v1beta1.DeploymentStatus{},
},
v1beta1.DeploymentStatus{},
NewVersion: "latest",
CurrentVersion: "latest",
},
wantShouldUpdateDeployment: true,
wantErr: false,
@ -107,26 +115,8 @@ func TestProvider_checkUnversionedDeployment(t *testing.T) {
v1beta1.DeploymentStatus{},
},
},
wantUpdated: v1beta1.Deployment{
meta_v1.TypeMeta{},
meta_v1.ObjectMeta{
Name: "dep-1",
Namespace: "xxxx",
Annotations: map[string]string{},
Labels: map[string]string{types.KeelPolicyLabel: "all"},
},
v1beta1.DeploymentSpec{
Template: v1.PodTemplateSpec{
Spec: v1.PodSpec{
Containers: []v1.Container{
v1.Container{
Image: "gcr.io/v2-namespace/goodbye-world:earliest",
},
},
},
},
},
v1beta1.DeploymentStatus{},
wantUpdatePlan: &UpdatePlan{
Deployment: v1beta1.Deployment{},
},
wantShouldUpdateDeployment: false,
wantErr: false,
@ -158,26 +148,30 @@ func TestProvider_checkUnversionedDeployment(t *testing.T) {
v1beta1.DeploymentStatus{},
},
},
wantUpdated: v1beta1.Deployment{
meta_v1.TypeMeta{},
meta_v1.ObjectMeta{
Name: "dep-1",
Namespace: "xxxx",
Annotations: map[string]string{forceUpdateImageAnnotation: "karolisr/keel:0.2.0"},
Labels: map[string]string{types.KeelPolicyLabel: "force"},
},
v1beta1.DeploymentSpec{
Template: v1.PodTemplateSpec{
Spec: v1.PodSpec{
Containers: []v1.Container{
v1.Container{
Image: "karolisr/keel:0.2.0",
wantUpdatePlan: &UpdatePlan{
Deployment: v1beta1.Deployment{
meta_v1.TypeMeta{},
meta_v1.ObjectMeta{
Name: "dep-1",
Namespace: "xxxx",
Annotations: map[string]string{forceUpdateImageAnnotation: "karolisr/keel:0.2.0"},
Labels: map[string]string{types.KeelPolicyLabel: "force"},
},
v1beta1.DeploymentSpec{
Template: v1.PodTemplateSpec{
Spec: v1.PodSpec{
Containers: []v1.Container{
v1.Container{
Image: "karolisr/keel:0.2.0",
},
},
},
},
},
v1beta1.DeploymentStatus{},
},
v1beta1.DeploymentStatus{},
NewVersion: "0.2.0",
CurrentVersion: "latest",
},
wantShouldUpdateDeployment: true,
wantErr: false,
@ -186,17 +180,19 @@ func TestProvider_checkUnversionedDeployment(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
p := &Provider{
implementer: tt.fields.implementer,
events: tt.fields.events,
stop: tt.fields.stop,
implementer: tt.fields.implementer,
sender: tt.fields.sender,
approvalManager: tt.fields.approvalManager,
events: tt.fields.events,
stop: tt.fields.stop,
}
gotUpdated, gotShouldUpdateDeployment, err := p.checkUnversionedDeployment(tt.args.policy, tt.args.repo, tt.args.deployment)
gotUpdatePlan, gotShouldUpdateDeployment, err := p.checkUnversionedDeployment(tt.args.policy, tt.args.repo, tt.args.deployment)
if (err != nil) != tt.wantErr {
t.Errorf("Provider.checkUnversionedDeployment() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(gotUpdated, tt.wantUpdated) {
t.Errorf("Provider.checkUnversionedDeployment() gotUpdated = %v, want %v", gotUpdated, tt.wantUpdated)
if !reflect.DeepEqual(gotUpdatePlan, tt.wantUpdatePlan) {
t.Errorf("Provider.checkUnversionedDeployment() gotUpdatePlan = %v, want %v", gotUpdatePlan, tt.wantUpdatePlan)
}
if gotShouldUpdateDeployment != tt.wantShouldUpdateDeployment {
t.Errorf("Provider.checkUnversionedDeployment() gotShouldUpdateDeployment = %v, want %v", gotShouldUpdateDeployment, tt.wantShouldUpdateDeployment)