don't return early

extension/credentialshelper/credentialshelper.go

@@ -88,7 +88,6 @@ func GetCredentials(image *types.TrackedImage) (creds *types.Credentials) {
 						"tracked_image": image,
 					}).Debug("extension.credentialshelper: credentials not found")
 				}
-				return &types.Credentials{}
 			} else {
 				return creds
 			}
@@ -97,5 +96,5 @@ func GetCredentials(image *types.TrackedImage) (creds *types.Credentials) {
 	log.WithFields(log.Fields{
 		"tracked_image": image,
 	}).Debug("extension.credentialshelper: credentials helper not found")
-	return creds
+	return &types.Credentials{}
 }

trigger/poll/manager_test.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/keel-hq/keel/approvals"
 	"github.com/keel-hq/keel/pkg/store/sql"
+
 	// "github.com/keel-hq/keel/cache/memory"
 	"github.com/keel-hq/keel/provider"
 	"github.com/keel-hq/keel/registry"