From ec44361d3ae9d83e527a1d0f9e58b83a76c10e23 Mon Sep 17 00:00:00 2001 From: Christoph Blecker Date: Tue, 13 Aug 2019 21:50:36 -0700 Subject: [PATCH] Fix malformed port in vsphere cloud provider test The port name previously didn't matter on these tests, but is now actively being checked in go1.12.8 and higher. https://github.com/golang/go/commit/3226f2d492963d361af9dfc6714ef141ba606713 --- .../legacy-cloud-providers/vsphere/vclib/connection_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/connection_test.go b/staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/connection_test.go index faa0a2d864..046b3de8a1 100644 --- a/staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/connection_test.go +++ b/staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/connection_test.go @@ -159,7 +159,7 @@ func TestWithValidThumbprint(t *testing.T) { func TestWithInvalidCaCertPath(t *testing.T) { connection := &vclib.VSphereConnection{ Hostname: "should-not-matter", - Port: "should-not-matter", + Port: "27015", // doesn't matter, but has to be a valid port CACert: "invalid-path", } @@ -172,7 +172,7 @@ func TestWithInvalidCaCertPath(t *testing.T) { func TestInvalidCaCert(t *testing.T) { connection := &vclib.VSphereConnection{ Hostname: "should-not-matter", - Port: "should-not-matter", + Port: "27015", // doesn't matter, but has to be a valid port CACert: fixtures.InvalidCertPath, }