From 590bf5530df72beac298570a589561aa82a029bd Mon Sep 17 00:00:00 2001 From: draveness Date: Fri, 15 Feb 2019 17:36:40 +0800 Subject: [PATCH] refactor: use FilterActivePods instead in replicaset controller --- pkg/controller/replicaset/replica_set.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pkg/controller/replicaset/replica_set.go b/pkg/controller/replicaset/replica_set.go index 1c269b8995..169fa85485 100644 --- a/pkg/controller/replicaset/replica_set.go +++ b/pkg/controller/replicaset/replica_set.go @@ -595,12 +595,7 @@ func (rsc *ReplicaSetController) syncReplicaSet(key string) error { return err } // Ignore inactive pods. - var filteredPods []*v1.Pod - for _, pod := range allPods { - if controller.IsPodActive(pod) { - filteredPods = append(filteredPods, pod) - } - } + filteredPods := controller.FilterActivePods(allPods) // NOTE: filteredPods are pointing to objects from cache - if you need to // modify them, you need to copy it first.