From 850de3d04de85c8fb8124ab3a116dcc5ba702486 Mon Sep 17 00:00:00 2001 From: Brad Davidson Date: Mon, 15 Dec 2025 22:37:45 +0000 Subject: [PATCH] lint: deep-exit Signed-off-by: Brad Davidson --- pkg/cli/cmds/log_linux.go | 2 ++ pkg/nodepassword/nodepassword_test.go | 2 ++ pkg/rootless/rootless.go | 2 ++ pkg/signals/signals.go | 2 ++ 4 files changed, 8 insertions(+) diff --git a/pkg/cli/cmds/log_linux.go b/pkg/cli/cmds/log_linux.go index 4d42e72b392..cd742b729f5 100644 --- a/pkg/cli/cmds/log_linux.go +++ b/pkg/cli/cmds/log_linux.go @@ -77,6 +77,8 @@ func forkIfLoggingOrReaping() error { systemd.SdNotify(true, "READY=1\n") cmd.Wait() + + //revive:disable-next-line:deep-exit os.Exit(cmd.ProcessState.ExitCode()) } return nil diff --git a/pkg/nodepassword/nodepassword_test.go b/pkg/nodepassword/nodepassword_test.go index 4c7a82f5a9f..2c803a0897a 100644 --- a/pkg/nodepassword/nodepassword_test.go +++ b/pkg/nodepassword/nodepassword_test.go @@ -15,6 +15,8 @@ import ( const migrateNumNodes = 10 const createNumNodes = 3 +//revive:disable:deep-exit + func Test_UnitAsserts(t *testing.T) { assertEqual(t, 1, 1) assertNotEqual(t, 1, 0) diff --git a/pkg/rootless/rootless.go b/pkg/rootless/rootless.go index a1931b5327f..a59b3bda772 100644 --- a/pkg/rootless/rootless.go +++ b/pkg/rootless/rootless.go @@ -80,6 +80,8 @@ func Rootless(stateDir string, enableIPv6 bool) error { if err := parent.Parent(*parentOpt); err != nil { logrus.Fatal(err) } + + //revive:disable-next-line:deep-exit os.Exit(0) return nil diff --git a/pkg/signals/signals.go b/pkg/signals/signals.go index 6bc55a9c6b5..fe6b02999d2 100644 --- a/pkg/signals/signals.go +++ b/pkg/signals/signals.go @@ -37,6 +37,8 @@ func SetupSignalContext() context.Context { cancel() s := <-signalHandler logrus.Infof("Second shutdown signal received: %s, exiting...", s) + + //revive:disable-next-line:deep-exit os.Exit(1) }()