Commit Graph

12 Commits (b8212e0b300e2cf68249802df892dfa561d475f8)

Author SHA1 Message Date
Anton Gilgur 429b474a4f
docs(github): comment out notational pieces of PR template (#1969)
github: comment out notational pieces of PR template

- the DCO and publishing sentences are not filled out during PRs
  and are purely notational
  - comment them out with HTML comments, as is common practice
    - example from a repo I maintain: f6db59613a/.github/issue_template.md?plain=1#L2
      - I copied that from other repos too
  - these comments are still visible to the PR author, just not visible
    when rendered, keeping the PR more concise

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-04-22 14:53:02 +09:00
Aikawa 4e05fd0da1
chore: update old URLs on pull_request_template.md (#1323) 2022-06-11 12:43:24 -05:00
Alexander Matyushentsev ba87cfc501
chore: get ready to rename master branch to main (#1292)
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
2022-05-24 08:29:40 -07:00
Oliver Bähler 752e1c0580
feat(all): Add Documentation Guidelines (#1099)
* feat(all): Add Documentation Guidelines

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>

* Satisfy Linter

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>

* Apply changes from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* fix: Also add *.gotmpl to argo-rollouts/.helmignore

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-01-24 20:18:51 +01:00
Oliver Bähler a70d156217
feat!: Improve Pull Request Template & Contributing Guidelines (#750)
* feat: improve documentation and require changelog

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>

* Bump Versions

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>

* Bump argo-rollouts

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* Reword Artifacthub -> Artifact Hub

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-07-09 13:08:43 +02:00
Marco Kilchhofer af0d6b8957
chore: Update PR template to include notes on DCO (#642)
Argo Project has moved from the CLA to the DCO:
- https://github.com/argoproj/argoproj/pull/24
- https://github.com/argoproj/argo-cd/pull/4966

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-03-31 10:35:48 -07:00
Vitaliy e141b401fe
Fixed #570: YAML parse error in argocd-notifications/templates/secret.yaml (#573)
Signed-off-by: Vitaliy Fuks <vitaliyf@users.noreply.github.com>

Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
2021-02-09 16:56:44 -08:00
Alex Collins ed127ea795
Fix bugs in CI set-up. (#144) 2019-10-31 11:28:02 -07:00
Alex Collins fc783d79d5
Enables Circle CI job that uses the `cl` lint tool on changed charts (#143) 2019-10-31 11:05:21 -07:00
Alex Collins 2d12ab4134
changes on master to scripts/publish.sh, (#135) 2019-10-24 09:17:26 -07:00
Alex Collins 574e5cfa18
Contributing (#116) 2019-09-19 17:36:12 -07:00
Alex Collins 04bf19d8a8
Adds pull request template (#113) 2019-09-19 22:16:57 +01:00