From df0cac1c2c3ad36f21a7f48dd28cbc14ae6b1744 Mon Sep 17 00:00:00 2001 From: Aikawa Date: Fri, 13 Jun 2025 02:17:45 +0900 Subject: [PATCH] docs(github): Add a PR checklist for PR unit (#3354) --- .github/pull_request_template.md | 1 + CONTRIBUTING.md | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ed14509e..b9fa71fd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,6 +11,7 @@ Checklist: * [ ] I have updated the chart changelog with all the changes that come with this pull request according to [changelog](https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#changelog). * [ ] Any new values are backwards compatible and/or have sensible default. * [ ] I have signed off all my commits as required by [DCO](https://github.com/argoproj/argoproj/blob/master/community/CONTRIBUTING.md). +* [ ] I have created a separate pull request for each chart according to [pull requests](https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#pull-requests) * [ ] My build is green ([troubleshooting builds](https://argo-cd.readthedocs.io/en/stable/developer-guide/ci/)). diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c20486f6..bea845c2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,6 +6,10 @@ Argo Helm is a collection of **community maintained** charts. Therefore we rely All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult [GitHub Help](https://help.github.com/articles/about-pull-requests/) for more information on using pull requests. See the above stated requirements for PR on this project. +> **Note** +> Please create a separate Pull Request for each chart. +> e.g: If your changes involve both argo-cd and argo-rollouts, please submit one PR for argo-cd and another separate. + ### Pull Request Title Linting We lint the title of your pull request to ensure it follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification. This is done using GitHub actions and the [action-semantic-pull-request](.github/workflows/pr-title.yml) workflow. We require the scope of the change to be included in the title. The scope should be the name of the chart you are changing. For example, if you are changing the `argo-cd` chart, the title of your pull request should be `fix(argo-cd): Fix typo in values.yaml`.