feat(argo-rollouts): Fix cluster role missing access in argo rollouts dashboard (#2081)

* docs(github): comment out notational pieces of PR template (#1969)

github: comment out notational pieces of PR template

- the DCO and publishing sentences are not filled out during PRs
  and are purely notational
  - comment them out with HTML comments, as is common practice
    - example from a repo I maintain: f6db59613a/.github/issue_template.md?plain=1#L2
      - I copied that from other repos too
  - these comments are still visible to the PR author, just not visible
    when rendered, keeping the PR more concise

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>

* Added missing permissions for argo rollouts dashboard cluster role - for config map, should be able to get

Signed-off-by: Tal Yitzhak <talyi@jfrog.com>

* Added missing permissions for argo rollouts dashboard cluster role - for config map, should be able to get

Signed-off-by: Tal Yitzhak <talyi@jfrog.com>

---------

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Tal Yitzhak <talyi@jfrog.com>
Signed-off-by: Tal Yitzhak <yitzhtal@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Tal Yitzhak <talyi@jfrog.com>
pull/2084/head^2 argo-rollouts-2.30.1
Tal Yitzhak 2023-05-27 17:51:41 +03:00 committed by GitHub
parent cf3a8eed84
commit 2fbc856637
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions

View File

@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.5.0
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.30.0
version: 2.30.1
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
@ -19,4 +19,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: added
description: ability to annotate controller Deployment
description: Missing get access for configmaps in argo rollouts dashboard service account role

View File

@ -71,6 +71,12 @@ rules:
verbs:
- list
- watch
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
- apiGroups:
- coordination.k8s.io
resources: