From 219778eb9d680cf16e7753c723035faba1018a81 Mon Sep 17 00:00:00 2001
From: Trevor Foster <trevor.foster@hotmail.ca>
Date: Fri, 13 Mar 2020 11:04:31 -0400
Subject: [PATCH] fix: Hotfix server.baseHref value not being used (#261)

---
 charts/argo/Chart.yaml                       | 2 +-
 charts/argo/templates/server-deployment.yaml | 2 +-
 charts/argo/values.yaml                      | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/charts/argo/Chart.yaml b/charts/argo/Chart.yaml
index 3f55e716..7aabd888 100644
--- a/charts/argo/Chart.yaml
+++ b/charts/argo/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "v2.6.1"
 description: A Helm chart for Argo Workflows
 name: argo
-version: 0.7.1
+version: 0.7.2
 icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
 home: https://github.com/argoproj/argo-helm
 maintainers:
diff --git a/charts/argo/templates/server-deployment.yaml b/charts/argo/templates/server-deployment.yaml
index ddb1821d..182c6edb 100644
--- a/charts/argo/templates/server-deployment.yaml
+++ b/charts/argo/templates/server-deployment.yaml
@@ -59,7 +59,7 @@ spec:
                 apiVersion: v1
                 fieldPath: metadata.namespace
           - name: BASE_HREF
-            value: /
+            value: {{ .Values.server.baseHref | quote }}
           resources:
             {{- toYaml .Values.server.resources | nindent 12 }}
       {{- with .Values.server.nodeSelector }}
diff --git a/charts/argo/values.yaml b/charts/argo/values.yaml
index 4823e925..bdc7d697 100644
--- a/charts/argo/values.yaml
+++ b/charts/argo/values.yaml
@@ -104,7 +104,9 @@ server:
   enabled: true
   # only show workflows where UI installed
   forceNamespaceIsolation: false
-  # UI BASE_HREF env variable
+  # only updates base url of resources on client side,
+  # it's expected that a proxy server rewrites the request URL and gets rid of this prefix
+  # https://github.com/argoproj/argo/issues/716#issuecomment-433213190
   baseHref: /
   image:
     # Overrides .images.tag if defined.