argoproj
/
argo-helm
mirror of https://github.com/argoproj/argo-helm.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity
argo-helm/.github/pull_request_template.md

17 lines
1.1 KiB
Markdown
Raw Normal View History

docs(github): comment out notational pieces of PR template (#1969) github: comment out notational pieces of PR template - the DCO and publishing sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from a repo I maintain: https://github.com/ezolenko/rollup-plugin-typescript2/blob/f6db59613a66f58c48310aa8fa785951970b5d6d/.github/issue_template.md?plain=1#L2 - I copied that from other repos too - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-04-22 05:53:02 +00:00
<!--
chore: Update PR template to include notes on DCO (#642) Argo Project has moved from the CLA to the DCO: - https://github.com/argoproj/argoproj/pull/24 - https://github.com/argoproj/argo-cd/pull/4966 Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-03-31 17:35:48 +00:00
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the *Details* link next to the DCO action for instructions on how to resolve this.
docs(github): comment out notational pieces of PR template (#1969) github: comment out notational pieces of PR template - the DCO and publishing sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from a repo I maintain: https://github.com/ezolenko/rollup-plugin-typescript2/blob/f6db59613a66f58c48310aa8fa785951970b5d6d/.github/issue_template.md?plain=1#L2 - I copied that from other repos too - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-04-22 05:53:02 +00:00
-->
chore: Update PR template to include notes on DCO (#642) Argo Project has moved from the CLA to the DCO: - https://github.com/argoproj/argoproj/pull/24 - https://github.com/argoproj/argo-cd/pull/4966 Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-03-31 17:35:48 +00:00
Contributing (#116)
2019-09-20 00:36:12 +00:00
Checklist:
Adds pull request template (#113)
2019-09-19 21:16:57 +00:00
chore: get ready to rename master branch to main (#1292) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
2022-05-24 15:29:40 +00:00
* [ ] I have bumped the chart version according to [versioning](https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#versioning)
* [ ] I have updated the documentation according to [documentation](https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#documentation)
* [ ] I have updated the chart changelog with all the changes that come with this pull request according to [changelog](https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#changelog).
Contributing (#116)
2019-09-20 00:36:12 +00:00
* [ ] Any new values are backwards compatible and/or have sensible default.
chore: update old URLs on pull_request_template.md (#1323)
2022-06-11 17:43:24 +00:00
* [ ] I have signed off all my commits as required by [DCO](https://github.com/argoproj/argoproj/blob/master/community/CONTRIBUTING.md).
* [ ] My build is green ([troubleshooting builds](https://argo-cd.readthedocs.io/en/stable/developer-guide/ci/)).
Fix bugs in CI set-up. (#144)
2019-10-31 18:28:02 +00:00
docs(github): comment out notational pieces of PR template (#1969) github: comment out notational pieces of PR template - the DCO and publishing sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from a repo I maintain: https://github.com/ezolenko/rollup-plugin-typescript2/blob/f6db59613a66f58c48310aa8fa785951970b5d6d/.github/issue_template.md?plain=1#L2 - I copied that from other repos too - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-04-22 05:53:02 +00:00
<!-- Changes are automatically published when merged to `main`. They are not published on branches. -->