From 7a4c34ec7e7c5d4a11f375553594e89af2d0cb92 Mon Sep 17 00:00:00 2001 From: Peter Keresztes Schmidt Date: Thu, 18 Mar 2021 12:59:14 +0100 Subject: [PATCH 1/2] RemoteCameraHttp: Fix a log message --- src/zm_remote_camera_http.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/zm_remote_camera_http.cpp b/src/zm_remote_camera_http.cpp index 3cfdc7412..010fc4fbc 100644 --- a/src/zm_remote_camera_http.cpp +++ b/src/zm_remote_camera_http.cpp @@ -289,7 +289,7 @@ int RemoteCameraHttp::ReadData(Buffer &buffer, unsigned int bytes_expected) { total_bytes_to_read -= bytes_read; } while (total_bytes_to_read); - Debug(4, "buffer: %s", buffer); + Debug(4, "buffer size: %d", static_cast(buffer)); return total_bytes_read; } // end readData From d1bbfdaf6b3067985a6669dedb9906fd4d1b8cb9 Mon Sep 17 00:00:00 2001 From: Peter Keresztes Schmidt Date: Thu, 18 Mar 2021 13:00:36 +0100 Subject: [PATCH 2/2] Build: Enable -Wconditionally-supported on GCC We want to have warnings if we use some implementation-specific features of GCC to be able to keep compatibility with clang. --- cmake/compiler/gcc/settings.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/cmake/compiler/gcc/settings.cmake b/cmake/compiler/gcc/settings.cmake index 87ff6e939..497db5a17 100644 --- a/cmake/compiler/gcc/settings.cmake +++ b/cmake/compiler/gcc/settings.cmake @@ -1,6 +1,7 @@ target_compile_options(zm-warning-interface INTERFACE -Wall + -Wconditionally-supported -Wextra -Wformat-security -Wno-cast-function-type