From c0242e736970a6d5d534a9f7618d5fc807acc76c Mon Sep 17 00:00:00 2001 From: Isaac Connor Date: Tue, 16 Mar 2021 13:28:00 -0400 Subject: [PATCH] Fix memleak when connect fails --- src/zm_stream.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/zm_stream.cpp b/src/zm_stream.cpp index 1f141ec65..e309a14bc 100644 --- a/src/zm_stream.cpp +++ b/src/zm_stream.cpp @@ -40,7 +40,7 @@ StreamBase::~StreamBase() { bool StreamBase::loadMonitor(int p_monitor_id) { monitor_id = p_monitor_id; - if ( !(monitor = Monitor::Load(monitor_id, false, Monitor::QUERY)) ) { + if ( !(monitor or (monitor = Monitor::Load(monitor_id, false, Monitor::QUERY))) ) { Error("Unable to load monitor id %d for streaming", monitor_id); return false; } @@ -52,6 +52,7 @@ bool StreamBase::loadMonitor(int p_monitor_id) { if ( !monitor->connect() ) { Error("Unable to connect to monitor id %d for streaming", monitor_id); + monitor->disconnect(); return false; }