fix problem editing users, a semi-colon screwed up the if statement.

Also change behaviour so that if a user is specified, and doesn't load, generate an error.
This also removes a search for empty user id in the db
pull/485/head
Isaac Connor 2014-07-08 10:52:55 -04:00
parent 70471936a7
commit 2be38d7f32
2 changed files with 22 additions and 10 deletions

View File

@ -25,11 +25,17 @@ if ( !canEdit( 'System' ) && !$selfEdit )
$view = "error";
return;
}
if ( !($newUser = dbFetchOne( 'SELECT * FROM Users WHERE Id = ?', NULL, ARRAY($_REQUEST['uid'])) ) ); {
$newUser = array();
$newUser['Username'] = $SLANG['NewUser'];
$newUser['Enabled'] = 1;
$newUser['MonitorIds'] = '';
if ( $_REQUEST['uid'] ) {
if ( !($newUser = dbFetchOne( 'SELECT * FROM Users WHERE Id = ?', NULL, ARRAY($_REQUEST['uid'])) ) ) {
$view = "error";
return;
}
} else {
$newUser = array();
$newUser['Username'] = $SLANG['NewUser'];
$newUser['Enabled'] = 1;
$newUser['MonitorIds'] = '';
}
$monitorIds = array_flip(explode( ',', $newUser['MonitorIds'] ));

View File

@ -25,11 +25,17 @@ if ( !canEdit( 'System' ) && !$selfEdit )
$view = "error";
return;
}
if ( !($newUser = dbFetchOne( 'SELECT * FROM Users WHERE Id = ?', NULL, ARRAY($_REQUEST['uid'])) ) ); {
$newUser = array();
$newUser['Username'] = $SLANG['NewUser'];
$newUser['Enabled'] = 1;
$newUser['MonitorIds'] = '';
if ( $_REQUEST['uid'] ) {
if ( !($newUser = dbFetchOne( 'SELECT * FROM Users WHERE Id = ?', NULL, ARRAY($_REQUEST['uid'])) ) ) {
$view = "error";
return;
}
} else {
$newUser = array();
$newUser['Username'] = $SLANG['NewUser'];
$newUser['Enabled'] = 1;
$newUser['MonitorIds'] = '';
}
$monitorIds = array_flip(explode( ',', $newUser['MonitorIds'] ));