ZoneMinder
/
zoneminder
mirror of https://github.com/ZoneMinder/zoneminder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Code style, add some parenthesis to make logic more clear

pull/3680/head
Isaac Connor 2023-03-21 10:03:51 -04:00
parent 34e3e99c99
commit 16ccac2325
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
onvif/modules/lib/ONVIF/Deserializer/MessageParser.pm
View File

@ -59,7 +59,7 @@ sub new {
if ! exists $SOAP::WSDL::Expat::MessageParser::LOADED_OF{ $self->{ class_resolver } };
}
return $self;
## calling the parent's calss new() dows not work here.
## calling the parent's class new() does not work here.
# return SOAP::WSDL::Expat::MessageParser->new($class, $args);
}
@ -90,11 +90,9 @@ sub _initialize {
if($_[0]->namespace($_[1]) eq URI_SOAP11_ENV) {
$_[0]{ soap_version } = '1.1';
# $soap_version_of{ident $_[0]} = '1.1';
}
elsif($_[0]->namespace($_[1]) eq URI_SOAP12_ENV) {
} elsif($_[0]->namespace($_[1]) eq URI_SOAP12_ENV) {
$_[0]{ soap_version } = '1.2';
}
else {
} else {
die "Bad namespace for SOAP envelope: " . $_[0]->recognized_string();
}
#print "Receiving SOAP " . $_[0]{ soap_version } ."\n";
@ -144,8 +142,7 @@ sub _initialize {
# That's slightly faster than $content_check{ $depth }->()
# and we don't have to pass $_[1] to the method.
# Yup, that's dirty.
return &{$content_check{ $depth }}
if exists $content_check{ $depth };
return &{$content_check{ $depth }} if exists $content_check{ $depth };
push @{ $path }, $_[1]; # step down in path
return if $skip; # skip inside __SKIP__
@ -204,7 +201,7 @@ sub _initialize {
my %attr = @_[2..$#_];
if (my $nil = delete $attr{nil}) {
# TODO: check namespace
if ($nil && $nil ne 'false') {
if ($nil && ($nil ne 'false')) {
undef $characters;
last ATTR if not (%attr);
}
@ -228,7 +225,7 @@ sub _initialize {
# check __SKIP__
if ($skip) {
return if $skip ne join '/', @{ $path }, $_[1];
return if $skip ne join('/', @{ $path }, $_[1]);
$skip = 0;
$_[0]->setHandlers( Char => $char_handler );
return;
@ -246,7 +243,7 @@ sub _initialize {
#
$SOAP::WSDL::XSD::Typelib::Builtin::anySimpleType::___value
->{ $$current } = $characters
if defined $characters && defined $current; # =~m{ [^\s] }xms;
if defined($characters) && defined($current); # =~m{ [^\s] }xms;
}
# empty characters