diff --git a/api/api.go b/api/api.go index 9d45f28a0..0047e622e 100644 --- a/api/api.go +++ b/api/api.go @@ -29,8 +29,8 @@ type ( } ) -func (a *api) run(configuration *Config) { - handler := a.newHandler(configuration) +func (a *api) run(settings *Settings) { + handler := a.newHandler(settings) if err := http.ListenAndServe(a.bindAddress, handler); err != nil { log.Fatal(err) } diff --git a/api/config.go b/api/config.go deleted file mode 100644 index 06b30faaa..000000000 --- a/api/config.go +++ /dev/null @@ -1,25 +0,0 @@ -package main - -import ( - "encoding/json" - "net/http" -) - -// Config defines the configuration available under the /config endpoint -type Config struct { - Swarm bool `json:"swarm"` - HiddenLabels pairList `json:"hiddenLabels"` -} - -// newConfig creates a new Config from command flags -func newConfig(swarm bool, labels pairList) Config { - return Config{ - Swarm: swarm, - HiddenLabels: labels, - } -} - -// configurationHandler defines a handler function used to encode the configuration in JSON -func configurationHandler(w http.ResponseWriter, r *http.Request, c *Config) { - json.NewEncoder(w).Encode(*c) -} diff --git a/api/handler.go b/api/handler.go index b38417bb4..3e48f258e 100644 --- a/api/handler.go +++ b/api/handler.go @@ -10,7 +10,7 @@ import ( ) // newHandler creates a new http.Handler with CSRF protection -func (a *api) newHandler(c *Config) http.Handler { +func (a *api) newHandler(settings *Settings) http.Handler { var ( mux = http.NewServeMux() fileHandler = http.FileServer(http.Dir(a.assetPath)) @@ -22,8 +22,8 @@ func (a *api) newHandler(c *Config) http.Handler { mux.Handle("/", fileHandler) mux.Handle("/dockerapi/", http.StripPrefix("/dockerapi", handler)) mux.Handle("/ws/exec", websocket.Handler(a.execContainer)) - mux.HandleFunc("/config", func(w http.ResponseWriter, r *http.Request) { - configurationHandler(w, r, c) + mux.HandleFunc("/settings", func(w http.ResponseWriter, r *http.Request) { + settingsHandler(w, r, settings) }) return CSRFHandler(newCSRFWrapper(mux)) } diff --git a/api/main.go b/api/main.go index f5ab609a2..d882a8dcd 100644 --- a/api/main.go +++ b/api/main.go @@ -33,11 +33,11 @@ func main() { TLSKeyPath: *tlskey, } - configuration := &Config{ + settings := &Settings{ Swarm: *swarm, HiddenLabels: *labels, } api := newAPI(apiConfig) - api.run(configuration) + api.run(settings) } diff --git a/api/settings.go b/api/settings.go new file mode 100644 index 000000000..801904f61 --- /dev/null +++ b/api/settings.go @@ -0,0 +1,17 @@ +package main + +import ( + "encoding/json" + "net/http" +) + +// Settings defines the settings available under the /settings endpoint +type Settings struct { + Swarm bool `json:"swarm"` + HiddenLabels pairList `json:"hiddenLabels"` +} + +// configurationHandler defines a handler function used to encode the configuration in JSON +func settingsHandler(w http.ResponseWriter, r *http.Request, s *Settings) { + json.NewEncoder(w).Encode(*s) +} diff --git a/app/app.js b/app/app.js index c09b7d08e..dd2c27d5c 100644 --- a/app/app.js +++ b/app/app.js @@ -155,5 +155,5 @@ angular.module('uifordocker', [ // You need to set this to the api endpoint without the port i.e. http://192.168.1.9 .constant('DOCKER_ENDPOINT', 'dockerapi') .constant('DOCKER_PORT', '') // Docker port, leave as an empty string if no port is requred. If you have a port, prefix it with a ':' i.e. :4243 - .constant('CONFIG_ENDPOINT', 'config') + .constant('CONFIG_ENDPOINT', 'settings') .constant('UI_VERSION', 'v1.5.0'); diff --git a/app/shared/services.js b/app/shared/services.js index 646d8fa75..d5cee721b 100644 --- a/app/shared/services.js +++ b/app/shared/services.js @@ -160,7 +160,7 @@ angular.module('uifordocker.services', ['ngResource', 'ngSanitize']) remove: {method: 'DELETE'} }); }]) - .factory('Config', ['$resource', 'CONFIG_ENDPOINT', function($resource, CONFIG_ENDPOINT) { + .factory('Config', ['$resource', 'CONFIG_ENDPOINT', function ConfigFactory($resource, CONFIG_ENDPOINT) { return $resource(CONFIG_ENDPOINT).get(); }]) .factory('Settings', ['DOCKER_ENDPOINT', 'DOCKER_PORT', 'UI_VERSION', function SettingsFactory(DOCKER_ENDPOINT, DOCKER_PORT, UI_VERSION) {