fix(doclinks): fix help link paths [EE-6861] (#11418)

pull/11430/head
Matt Hook 2024-03-19 11:46:41 +13:00 committed by GitHub
parent bd3440bf3c
commit 07de1b2c06
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 9 deletions

View File

@ -1,9 +1,11 @@
import { ReactNode } from 'react';
import { useDocsUrl } from '../PageHeader/ContextHelp/ContextHelp'; import { useDocsUrl } from '../PageHeader/ContextHelp/ContextHelp';
type HelpLinkProps = { type HelpLinkProps = {
docLink?: string; docLink: string;
target?: string; target?: string;
children?: React.ReactNode; children?: ReactNode;
}; };
export function HelpLink({ export function HelpLink({
@ -14,7 +16,7 @@ export function HelpLink({
const docsUrl = useDocsUrl(docLink); const docsUrl = useDocsUrl(docLink);
return ( return (
<a href={docsUrl} target={target} rel="noreferrer"> <a href={docsUrl} target={target} rel="noopener noreferrer">
{children} {children}
</a> </a>
); );

View File

@ -17,7 +17,7 @@ import { confirmDestructive } from '@@/modals/confirm';
import { buildConfirmButton } from '@@/modals/utils'; import { buildConfirmButton } from '@@/modals/utils';
import { InformationPanel } from '@@/InformationPanel'; import { InformationPanel } from '@@/InformationPanel';
import { TextTip } from '@@/Tip/TextTip'; import { TextTip } from '@@/Tip/TextTip';
import { useDocsUrl } from '@@/PageHeader/ContextHelp/ContextHelp'; import { HelpLink } from '@@/HelpLink';
import { useContainers } from '../queries/containers'; import { useContainers } from '../queries/containers';
import { useSystemLimits } from '../../proxy/queries/useInfo'; import { useSystemLimits } from '../../proxy/queries/useInfo';
@ -78,8 +78,6 @@ function CreateForm() {
isDockerhubRateLimited, isDockerhubRateLimited,
}); });
const createContDocUrl = useDocsUrl('/docker/containers/create');
if (!envQuery.data || !initialValuesQuery) { if (!envQuery.data || !initialValuesQuery) {
return null; return null;
} }
@ -103,10 +101,10 @@ function CreateForm() {
<TextTip> <TextTip>
The new container may fail to start if the image is changed, and The new container may fail to start if the image is changed, and
settings from the previous container aren&apos;t compatible. Common settings from the previous container aren&apos;t compatible. Common
causes include entrypoint, cmd or causes include entrypoint, cmd or{' '}
<a href={createContDocUrl} target="_blank" rel="noreferrer"> <HelpLink docLink="/user/docker/containers/advanced">
other settings other settings
</a>{' '} </HelpLink>{' '}
set by an image. set by an image.
</TextTip> </TextTip>
</InformationPanel> </InformationPanel>