OpenHAB
/
openhab-webui
mirror of https://github.com/openhab/openhab-webui.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Resolve SAT errors (#36) 

Signed-off-by: Wouter Born <github@maindrain.net>
pull/39/head
Wouter Born 2019-03-14 20:20:40 +01:00 committed by Kai Kreuzer
parent 9173058ce9
commit 671f926883
8 changed files with 50 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
org.openhab.ui.dashboard/pom.xml
View File

@ -3,8 +3,8 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.openhab.core.bundles</groupId>
<artifactId>org.openhab.core.reactor.bundles</artifactId>
<groupId>org.openhab.ui</groupId>
<artifactId>pom</artifactId>
<version>2.5.0-SNAPSHOT</version>
</parent>

15
org.openhab.ui.habot/build.properties
View File

@ -1,15 +0,0 @@
bin.includes = META-INF/,\
.,\
NOTICE,\
ESH-INF/,\
OSGI-INF/,\
lib/,\
lib/opennlp-tools-1.8.3.jar,\
lib/bcprov-jdk15on-154.jar,\
lib/jose4j-0.6.3.jar,\
web/dist/pwa-mat/
output = target/classes/
source.. = src/main/java/,\
src/main/resources/
src.excludes = src/test/java/\
src/test/resources/

20
org.openhab.ui.paper/build.properties
View File

@ -1,20 +0,0 @@
output.. = target/classes/
bin.includes = META-INF/,\
.,\
OSGI-INF/,\
NOTICE,\
web/css/,\
web/fonts/,\
web/img/,\
web/index.html,\
web/js/,\
web/partials/
source.. = src/main/java/
bin.excludes = web/fonts/Roboto-Thin.woff,\
web/fonts/Roboto-ThinItalic.woff,\
web/fonts/Roboto-RegularItalic.woff,\
web/fonts/Roboto-MediumItalic.woff,\
web/fonts/Roboto-LightItalic.woff,\
web/fonts/Roboto-BoldItalic.woff,\
web/fonts/Roboto-BlackItalic.woff,\
web/fonts/Roboto-Black.woff

29
tools/checkstyle_suppressions.xml
View File

@ -1,29 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions>
<suppress files="build.properties" checks="AboutHtmlCheck" />
<!-- These suppressions define which files to be suppressed for which checks. -->
<suppress files=".+[\\/]internal[\\/].+\.java" checks="JavadocType|JavadocVariable|JavadocMethod|JavadocFilterCheck"/>
<suppress files=".+DTO\.java" checks="JavadocType|JavadocVariable|JavadocMethod|JavadocFilterCheck" />
<suppress files=".+Impl\.java" checks="JavadocType|JavadocVariable|JavadocMethod|JavadocFilterCheck"/>
<!-- The WiFi led binding contains test packages that shouldn't be included in the binary build -->
<!-- The CometVisu UI contains files in the resources folder that are used only during the build -->
<suppress files=".+org.openhab.binding.wifiled.+|.+org.openhab.ui.cometvisu.+" checks="BuildPropertiesCheck"/>
<!-- Homematic and Tellstick bindings are creating and configuring things dynamically, they will log false positives for unused configuration -->
<!-- IO and Voice bundles have specific use cases - they use only the config .xml files and will log false positives as well -->
<suppress files=".+org.openhab.binding.homematic.+|.+org.openhab.binding.tellstick.+|.+org.openhab.io.+|.+org.openhab.voice.+" checks="EshInfXmlCheck"/>
<!-- All generated files will skip the author tag check -->
<suppress files=".+[\\/]gen[\\/].+\.java" checks="AuthorTagCheck"/>
<!-- Some checks will be supressed for test bundles -->
<suppress files=".+.test[\\/].+" checks="RequireBundleCheck"/>
<!-- There is a single class inside org.openhab.voice.voicerss.tool, which is meant to be called from the command line.
Moving it to "internal" is also not ideal as it is a documented tool. -->
<suppress files=".+org.openhab.voice.voicerss.+" checks="PackageExportsNameCheck"/>
<!-- Allow the usage of scheduleAtFixedRate in FadingWiFiLEDDriver class -->
<suppress files=".+org.openhab.binding.wifiled.handler.FadingWiFiLEDDriver.java" checks="AvoidScheduleAtFixedRateCheck"/>
<suppress files=".+[\\/]pom\.xml" checks="OnlyTabIndentationInXmlFilesCheck"/>
<suppress files=".+[\\/]OSGI-INF[\\/]org.openhab.+\.xml" checks="OnlyTabIndentationInXmlFilesCheck|NewlineAtEndOfFileCheck"/>
<suppress files=".+org.openhab.binding.yeelight.+" checks="OutsideOfLibExternalLibrariesCheck" />
<suppress files=".+org.openhab.ui.paper.+" checks="OutsideOfLibExternalLibrariesCheck|ManifestExternalLibrariesCheck|BuildPropertiesExternalLibrariesCheck" />
</suppressions>

6
tools/checkstyle.properties → tools/static-code-analysis/checkstyle/ruleset.properties
View File

@ -1,6 +1,6 @@
checkstyle.forbiddenPackageUsageCheck.exceptions=
checkstyle.forbiddenPackageUsageCheck.forbiddenPackages=com.google.common
checkstyle.headerCheck.content=^/\\*\\*$\\n^ \\* Copyright \\(c\\) {0}-{1} Contributors to the openHAB project$\\n^ \\*$\\n^ \\* See the NOTICE file\\(s\\) distributed with this work for additional$\\n^ \\* information.$\\n^ \\*$\\n^ \\* This program and the accompanying materials are made available under the$\\n^ \\* terms of the Eclipse Public License 2\\.0 which is available at$\\n^ \\* http://www.eclipse.org/legal/epl\\-2\\.0$\\n^ \\*$\\n^ \\* SPDX-License-Identifier: EPL-2.0$
checkstyle.headerCheck.values=2010,2019
checkstyle.pomXmlCheck.currentVersionRegex=^2\.5\.0
checkstyle.forbiddenPackageUsageCheck.forbiddenPackages=com.google.common
checkstyle.forbiddenPackageUsageCheck.exceptions=
checkstyle.requiredFilesCheck.files=build.properties,pom.xml,META-INF/MANIFEST.MF
checkstyle.requiredFilesCheck.files=pom.xml

16
tools/static-code-analysis/checkstyle/suppressions.xml Normal file
View File

@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions>
<suppress files="build.properties" checks="AboutHtmlCheck" />
<!-- These suppressions define which files to be suppressed for which checks. -->
<suppress files=".+[\\/]pom\.xml" checks="OnlyTabIndentationCheck"/>
<suppress files=".+[\\/]gen[\\/].+\.java" checks="AuthorTagCheck"/>
<suppress files=".+[\\/]internal[\\/].+\.java" checks="JavadocType|JavadocVariable|JavadocMethod|JavadocFilterCheck"/>
<suppress files=".+Impl\.java" checks="JavadocType|JavadocVariable|JavadocMethod|JavadocFilterCheck"/>
<suppress files=".+.test[\\/].+" checks="RequireBundleCheck"/>
<!-- The CometVisu UI contains files in the resources folder that are used only during the build -->
<suppress files=".+org.openhab.ui.cometvisu.+" checks="BuildPropertiesCheck"/>
<suppress files=".+org.openhab.ui.paper.+" checks="OutsideOfLibExternalLibrariesCheck|ManifestExternalLibrariesCheck|BuildPropertiesExternalLibrariesCheck" />
</suppressions>

0
tools/static-code-analysis/pmd/suppressions.properties Normal file
View File

29
tools/static-code-analysis/spotbugs/suppressions.xml Normal file
View File

@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter>
<!-- Excludes all bugs with priority higher than 4 -->
<Match>
<Rank value="4"/>
<Not>
<Bug pattern="SLF4J_LOGGER_SHOULD_BE_NON_STATIC"/>
</Not>
</Match>
<!-- This pattern is not wanted as it reports usage of Throwable.getMessage() as argument to SLF4G logger -->
<Match>
<Bug pattern="SLF4J_MANUALLY_PROVIDED_MESSAGE"/>
</Match>
<!-- Allow util classes to have static loggers -->
<Match>
<Class name="~.*Utils"/>
<Bug pattern="SLF4J_LOGGER_SHOULD_BE_NON_STATIC"/>
</Match>
<Match>
<Class name="~.*Util"/>
<Bug pattern="SLF4J_LOGGER_SHOULD_BE_NON_STATIC"/>
</Match>
<Match>
<Bug pattern="SLF4J_UNKNOWN_ARRAY"/>
</Match>
<Match>
<Bug pattern="SLF4J_SIGN_ONLY_FORMAT"/>
</Match>
</FindBugsFilter>