OpenHAB
/
openhab-core
mirror of https://github.com/openhab/openhab-core.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
2,702 Commits
10 Branches
121 Tags
67 MiB
Commit Graph

385 Commits (6922d60fd99562103f9f67f8b254f932a3d70759)

Author SHA1 Message Date
Wouter Born bf14e1077f
Apply Spotless, resolve itest runbundles for 3.1.0 (#1982) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-22 10:01:42 +01:00
jenkins 965531696b [unleash-maven-plugin] Preparation for next development cycle. 2020-12-20 22:24:39 +00:00
Kai Kreuzer cea96b3d81
[automation] Do not consider disabled things for start level 80 (#1968) 
Fixes #1967

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-20 09:44:45 +01:00
Kai Kreuzer 69b18e5a70
Introduce ready marker to correctly set start level 80 (#1953) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-17 11:16:56 +01:00
Wouter Born 001c00a8c3
Fix remaining deprecations (#1918) 
Fixes #1408

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-13 12:22:43 +01:00
openhab-bot 91469ddb9b
New Crowdin updates (#1921) 
* New translations units.properties (Portuguese, Brazilian)
* New translations firmware.properties (Portuguese, Brazilian)
* New translations validation.properties (Portuguese, Brazilian)
 2020-12-12 23:29:54 +01:00
Christoph Weitkamp e909a81f4b
Removed references to not existing category (#1915) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-12-12 22:35:20 +01:00
Christoph Weitkamp 3293bac779
Register CommunicationManager as ItemChannelLink listener (#1917) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-12-12 21:55:37 +01:00
Kai Kreuzer 076ac3fe15
Implemented start level service (#1914) 
Fixes #1637
Fixes #1777
Fixes #1734
Fixes #1823
Fixes #1808

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-12 14:34:37 +01:00
Christoph Weitkamp fe677966af
[link] Use constructor injection (#1911) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-12-10 23:07:56 +01:00
Wouter Born fea6237153
Improve ChannelLinkNotifier.removed and AbstractUID.getAsString performance (#1909) 
Fixes #1908

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-10 10:20:35 +01:00
Wouter Born 0dabc63423
Update "o.e.sh" references (#1910) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-10 10:15:48 +01:00
Wouter Born 0abf1aa987
Remove SmartHome leftovers (#1901) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-08 12:49:06 +01:00
Wouter Born 13c2d7bf2b
Rename classes with "SmartHome" in their name (#1896) 
* Rename SmartHomeUnits to Units
* Rename SmartHome Servlets and HTTP Context

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-12-06 23:35:37 +01:00
silamon 34a3487e3e
Disable AutoUpdateManager for GroupItems (#1862) 
* Disable AutoUpdateManager for GroupItems

Fixes #1330 

Signed-off-by: Simon Lamon <simonlamon93@hotmail.com>
 2020-12-03 17:20:59 +01:00
Kai Kreuzer 85fcb7b141
Cache safe call proxies for profiles instead of continuously recreating them (#1880) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-12-03 09:28:07 +01:00
Christoph Weitkamp cd0654806b
Fixed config description (#1873) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-12-01 08:39:52 +01:00
Christoph Weitkamp 818a7c82fa
Get only relevant links instead of all (#1874) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-11-30 19:31:18 +01:00
Marcel aa317d8c85
Fix typo in TriggerChannelTypeBuilder (#1866) 
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com
 2020-11-29 23:07:57 +01:00
Christoph Weitkamp 109fae9974
[profiles] Added 'Hysteresis' profile (#1726) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-11-29 00:21:43 +01:00
Christoph Weitkamp 7cb746ece1
Changed comparison from equals() to reference (#1817) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-11-14 13:46:03 +01:00
Christoph Weitkamp 91e16e0f80
Print 'ItemChannelLink' configuration in output of console commands (#1794) 
* Print ItemChannelLink configuration in output of console commands

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-11-05 09:22:01 +01:00
Wouter Born 2f2bfde500
Remove Map null annotation workarounds (#1780) 
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-11-03 22:12:22 +01:00
Wouter Born 0281c10036
[infrastructure] add external null-annotations (#1775) 
Add EEAs and fix null analysis errors.

Related to:

* #888
* openhab/openhab-addons#8848

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-11-03 21:33:48 +01:00
Wouter Born c5541a0391
Remove deprecated handleUpdate from ThingHandler (#1669) 
The handleUpdate method was deprecated when profiles were introduced (see eclipse-archived/smarthome#4108).
Instead the "follow profile" can be used which forwards item updates as commands to handlers.
This profile works with any binding instead of only those that implement the handleUpdate method.

Related to #1408

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-24 14:53:33 +02:00
Wouter Born 2dd1a03abd
Fix item channel links not properly initialized (#1634) 
* Fix item channel links not properly initialized
* Add ChannelLinkNotifierOSGiTest
* Send at most one channelLinked event per linked thing channel when activating ChannelLinkNotifier
* Send channelUnlinked event only if all items are unlinked
* Use Registry stream instead of getAll

Fixes #1596

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-24 08:41:05 +02:00
Wouter Born f845772ab0
Remove deprecated BaseThingHandler.initialize() (#1665) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-23 13:33:05 +02:00
Kai Kreuzer 57d4487f36
Removed ChannelItemProvider (#1643) 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-09-14 09:21:55 +02:00
Christoph Weitkamp eab9be1410
Removed deprecated constructors and methods from Thing API (#1414) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-09-13 13:53:12 +02:00
Wouter Born b3880ebe88
Remove deprecated methods from Configuration, UID and ThingHelper (#1629) 
Removes the following deprecated methods:

* org.openhab.core.config.core.Configuration.get​(Object)
* org.openhab.core.config.core.Configuration.remove​(Object)
* org.openhab.core.thing.UID.getSegments()
* org.openhab.core.thing.util.ThingHelper.ensureUnique​(Collection<Channel>)

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-09 09:22:27 +02:00
Wouter Born 2273f8976f
Fix potential NPE in ProfileCallbackImpl (#1627) 
Also annotates ItemChannelLink.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-07 15:13:06 +02:00
Wouter Born 02404b2fa7
Fix null analysis errors/warnings (#1626) 
The changes in #1614 caused null analysis errors in CommunicationManager.createCallback and caused unnecessary null check warnings in ProfileCallbackImpl.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-09-07 12:12:31 +02:00
Christoph Weitkamp a87318aace
Added missing nullness annotations in profile implementations (#1614) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-08-30 14:02:23 +02:00
Wouter Born 12a5d08691
Allow property value to be updated to null (#1611) 
With the changes in #1598 the BaseThingHandler could no longer update property values to null.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-26 12:06:53 +02:00
pacive 184366a1a5
Use TypeParser in ProfileCallbackImpl#sendUpdate for StringType state (#1603) 
* Use TypeParser in ProfileCallbackImpl#sendUpdate for StringType state

Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
 2020-08-24 23:49:19 +02:00
Wouter Born 057604cc2d
Use new Collection API methods (#1598) 
Using the new methods there will be less and more readable code.

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-22 23:04:11 +02:00
Wouter Born 7300734585
Use "openhab" event topic prefix (#1587) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-11 21:16:49 +02:00
Wouter Born d3ea6063c0
Migrate to JUnit 5 (#1580) 
* Migrates all tests to the JUnit 5 Jupiter API
* Updates bnd to 5.1.2
* Updates maven-surefire-plugin to 3.0.0-M5
* Updates Mockito to 3.4.6
* Updates Hamcrest to 2.2
* Removes org.openhab.core.boot POM dependencies

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-08-09 14:36:46 +02:00
Christoph Weitkamp 419c927587
Enhanced JavaDoc for ChannelBuilder (#1572) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-07-29 18:14:54 +02:00
Paul Vogel ed21001891
Cleanup tests: Simplify assertEquals with boolean to assertTrue or assertFalse (#1567) 
Signed-off-by: Paul Vogel <pavog@users.noreply.github.com>
 2020-07-23 22:19:00 +02:00
Christoph Weitkamp 4b77d29f13
Added nullness annotations and constructor injection for ConsoleCommandExtensions (#1549) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-07-17 21:12:08 +02:00
Christoph Weitkamp 729efeb37a
Improved ThingHandlerService registrations / removals (#1548) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-07-16 19:11:44 +02:00
J-N-K 558f518feb
Added utility console commnds for removing orphan links (#1395) 
* Added utility console commands for removing orphan links

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
 2020-07-15 10:30:31 +02:00
Christoph Weitkamp 8808f04c30
Removed dependency on 'org.apache.commons.io' (#1441) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-21 15:17:00 +02:00
Christoph Weitkamp 3eb93bf13a
Removed deprecated constructors and methods from Config API (#1448) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-20 22:16:54 +02:00
Wouter Born f3508e4775
Use constructor injection and update null annotations (#1487) 
* Use constructor injection and update null annotations

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-05-20 17:29:18 +02:00
Christoph Weitkamp 3d78cb6df6
[thing] Removed 'getThingByUID()' method from 'BaseBridgeHandler' (#1465) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-05-17 21:47:58 +02:00
Wouter Born 84d9438737
Add null annotations to REST resources (#1475) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-05-17 19:32:35 +02:00
Wouter Born 61e17ce39e
Upgrade SAT and Spotless, apply Spotless and enable check (#1446) 
* Update SAT and Spotless dependencies
* Apply Spotless and enable check

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-26 11:15:24 +02:00
Christoph Weitkamp d371a34321
Removed dependency on 'org.apache.commons.lang' (#1433) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-04-22 14:32:31 +02:00
Wouter Born 92027ca922
Use .equals() on constants and literals to prevent NPEs (#1420) 
* Use .equals() on constants and literals to prevent NPEs

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-16 07:40:49 +02:00
Christoph Weitkamp b770bb1b4a
Removed 'StateDescriptionProvider' interface (#1413) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-04-14 21:15:29 +02:00
Wouter Born fb7a7ac421
Add null annotations to providers and ThingManager (#1412) 
* Add null annotations to providers and ThingManager

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-11 08:29:12 +02:00
Christoph Weitkamp aae207bfe9
Removed 'advanced' attribute from 'ChannelGroupType' (#1410) 
* Removed 'advanced' attribute from ChannelGroupType

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-04-07 09:57:28 +02:00
Wouter Born 945afcdb1a
Add and fix more null annotations (#1407) 
* Add and fix more null annotations
* Add more @NonNullByDefault and @Nullable annotations
* Remove unnecessary @NonNull annotations
* Fix a few other trivial SAT issues
* Add constructor injection for MDNSDiscoveryService

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-04-06 10:45:39 +02:00
Christoph Weitkamp 1981e548aa
[thing] Dynamic state/command provider should not return original description (#1399) 
* Clarify return values for implementation
* Dynamic state/command provider should not return original descritpion
* Added ERROR log message
* Added integration test for CommandDescriptionProvider

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-04-06 08:49:26 +02:00
Kai Kreuzer 857679f66b
removed ThingLinkManager and with it the auto-linking feature and "Simple Mode" (#1385) 
* removed ThingLinkManager and with it the auto-linking feature and "Simple Mode"

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* removed feature from REST API as well

Signed-off-by: Kai Kreuzer <kai@openhab.org>

* removed tests

Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2020-03-03 00:23:04 +01:00
silamon bb3e8694e3
ChannelDTO bugfixes (#1346) 
* Fix bug in ChannelDTOMapper
* Add AutoUpdatePolicy to ChannelDTO

Also-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Simon Lamon <simonlamon93@hotmail.com>
 2020-02-02 21:56:01 +01:00
Michael Reitler (former Michael Dicke) e7f49dc462
[ThingManagerImpl] Prevent multiple handler inits on thing enabling (#1353) 
When a thing is enabled, the `ThingManagerImpl` takes care of calling `ThingHandler#initialize()`.
That makes totally sense if the thing was disabled before. However, if `setEnabled(thingUID, true)` is called for a thing which was already enabled, it causes an additional initialization.
Since concurrent hanlder initializations may cause trouble, it is safer to prevent this. Therefore enabling a thing (including starting its thing handler) should only be performed if the thing is disabled.

Signed-off-by: Michael Reitler <michael.dicke@smail.inf.h-brs.de>
 2020-02-02 21:53:25 +01:00
Christoph Weitkamp 8a9d007e0b Added nullness annotations to 'ThingActions' and 'ThingHandlerService' (#1317) 
* Minor code improvements; Added nullness annotations to ThingActions and ThingHandlerService
* Revert renaming of 'thingRegistry' property

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-01-25 16:21:47 +01:00
Christoph Weitkamp 08da8de5cf Moved "ESH-INF/" folders to "OH-INF/" folders (#1328) 
* Moved ESH-INF folders to OH-INF folders

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-01-17 15:29:18 +01:00
Wouter Born 18d0a52d02 Switch to Java 11 and drop Java 8 support (#1305) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-12 22:32:28 +01:00
Christoph Weitkamp 7d42607e4c Streamline format of event outputs (#1318) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-01-09 12:40:25 +01:00
Christoph Weitkamp 84009652a8 Changed configurationPid prefixes from 'org.openhab.core' ot 'org.openhab' (#1314) 
* Changed configurationPid prefixes from 'org.openhab.core' ot 'org.openhab'

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2020-01-02 09:12:34 +01:00
Wouter Born 3811cb9560 Update copyright headers to 2020 (#1309) 
* Update copyright headers to 2020

Signed-off-by: Wouter Born <github@maindrain.net>
 2020-01-01 18:06:34 +01:00
Christoph Weitkamp 800956598b Applied spotless formatter (#1302) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-30 22:55:19 +01:00
Christoph Weitkamp b505847544 Simplify code for 'updateProperty' method (#1300) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-30 09:38:46 +01:00
Christoph Weitkamp 59675788e0 Renamed packages 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-28 12:18:16 +01:00
Christoph Weitkamp fca7c215a5 Moved files to new location 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-12-28 12:18:16 +01:00
jenkins bc6a380297 [unleash-maven-plugin] Preparation for next development cycle. 2019-12-15 14:55:36 +00:00
Christoph Weitkamp e85e1a6f44 Removed dependency on 'org.apache.commons.collections' (#1244) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-28 18:43:10 +01:00
Christoph Weitkamp 0046774eb6 Set UNINITIALIZED -> HANDLER_MISSING_ERROR after enabling a Thing and handler is missing (#1243) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-28 15:55:59 +01:00
Christoph Weitkamp 764b5845a6 [thing] Call `removeItem()` with item name instead of `ThingUID` (#1230) 
* Added unit test to cover #1226
* Call 'removeItem()' with item name instead of ThingUID
* Added nullness annotations
* Use constructor injection

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-19 17:34:05 +01:00
Christoph Weitkamp 931b2007c5 Removed access to 'BundleContext' from 'BaseThingHandler' (#1214) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-17 21:44:08 +01:00
Wouter Born 403b55c8fc Parameterized logging fixes (#1213) 
Make sure Throwables are not be substituted into log messages so they can be formatted according to the logging configuration.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-11-14 20:08:06 +01:00
Christoph Weitkamp ce404e0a84 Added German translations for profiles (#1182) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-06 10:45:22 +01:00
Wouter Born f002a21da5 Fix SAT errors/warnings in resources and tests (#1178) 
Fixes SAT errors/warnings in resources and tests reported by SAT 0.8.0-SNAPSHOT.

Related to openhab/static-code-analysis#363

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-11-03 11:04:19 +01:00
Christoph Weitkamp 1f9a6f685d Consider more than one value when applying the default value(s) for Things and Channels (#1067) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-11-01 22:23:52 +01:00
Christoph Weitkamp 45602fa184 [xml] Feature thing xml constructor injection (#1167) 
* Added contructor injection to thing xml
* Removed Nullable from getChannels and getChannelGroups

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-27 19:24:12 +01:00
Christoph Weitkamp 12d91f7da9 [i18n] Refactoring and annotations (#1161) 
* Added nullness annotations to 'RuleTemplateI18nUtil'
* Added nullness annotations to 'ConfigDescriptionGroupI18nUtil'
* Moved 'ConfigDescriptionI18nUtil' into internal package
* Moved 'ConfigDescriptionGroupI18nUtil' into internal package
* Moved 'ThingTypeI18nUtil' into internal package
* Use 'ConfigI18nLocalizationService' instead of 'ConfigDescriptionI18nUtil'
* Use default labels / descriptions if application of localization is not successful
* Resolved itest.bndrun files

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-27 11:17:52 +01:00
Wouter Born 2430256b6a Add null annotations to registries (#1134) 
Adds null annotations to all registries, the interfaces they implement and a few other classes.

Also-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-23 07:36:56 +02:00
Wouter Born be69d2254e Use !isEmpty() instead of "size() > 0" or "size() != 0" (#1155) 
* Use !isEmpty() instead of "size() > 0" or "size() != 0"

!isEmpty() expresses the intent more clearly and is therefore preferred.
Counting the number of elements can also be an expensive operation e.g. when using linked lists.

Co-Authored-By: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-21 09:00:52 +02:00
Christoph Weitkamp 22ba5d92c1 Minor profile improvements (#1132) 
* Minor code improvements in profile factory
* Added integration test to check if factory creates all available profiles

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-19 15:14:57 +02:00
Christoph Weitkamp 0fdd691c22 Removed superflous resources (#1137) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-18 22:28:37 +02:00
Mark Hilbush 8396a17d2d Add system profile for a 'rawbutton-on-off-switch' (#1131) 
* Add `rawbutton-on-off-switch` profile and tests

Signed-off-by: Mark Hilbush <mark@hilbush.com>
 2019-10-14 22:22:18 +02:00
Christoph Weitkamp 91617d8af8 Fixed POM XML Shema Definition path (#1119) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-12 08:52:16 +02:00
Wouter Born 12e8edc039 Use diamond operator (#1114) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-11 02:29:47 -07:00
Wouter Born 3d52c72a91 Fix SAT AuthorContributionDescriptionCheck findings (#1110) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-10 11:36:05 +02:00
Wouter Born 90005e4a56 Fix NoEmptyLineSeparatorCheck and NewlineAtEndOfFileCheck SAT findings (#1108) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-08 22:19:54 -07:00
Wouter Born 08a1f9a86d Fix SAT constant/variable name findings (#1106) 
Fixes wrong names identified by the following rules:

* ConstantNameCheck
* LocalFinalVariableNameCheck
* LocalVariableNameCheck
* StaticVariableNameCheck

Most mismatches identified by the MemberNameCheck have also been fixed except for those where the variables are used in events/DTOs etc which would cause issues.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-08 22:19:00 -07:00
Wouter Born 12b3c1030f Fix SAT "Initial contribution" warnings (#1100) 
Fixes the SAT warning: First javadoc author should have "Initial contribution" contribution description.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-07 21:25:40 -07:00
Christoph Weitkamp c31a5aa7ef [storage] Added nullness annotations (#1099) 
* Added nullness annotations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-07 20:50:39 +02:00
Christoph Weitkamp 6a3c9b03ac Replaced orphaned 'registerHandlerLock' by 'thingLocks' (#1060) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-10-06 11:17:51 +02:00
Wouter Born f53beab04c Move thing unit tests (#1074) 
* Move thing unit tests

Moves the thing unit tests from the itests project to the bundle project.

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-10-03 19:52:40 +02:00
Christoph Weitkamp d2af7a350b [core] Removed access to 'ThingRegistry' from 'BaseThingHandler' (#1041) 
* Removed access to ThingRegistry from BaseThingHandler

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-29 12:26:46 +02:00
Christoph Weitkamp cd57f1d79c Refactoring of builders (#908) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-09-16 21:10:39 +02:00
Christoph Weitkamp f86d011884 Use constructor injection to simplify lifecycle (#987) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-24 23:49:24 +02:00
Christoph Weitkamp 3e38733b09 Fixed spelling in JavaDoc (#975) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-08-13 21:21:13 +02:00
Wouter Born 9d2f09936d Fix null annotations order and cleanup (#958) 
* Move null annotations between modifiers and variable type
* Remove redundant public modifiers from interfaces where applicable
* Remove redundant `@NonNull` annotations

Signed-off-by: Wouter Born <github@maindrain.net>
 2019-08-08 09:42:30 +02:00
Markus Rathgeb ef05b4d878 start with an upper case on "initial contribution" (#931) 
Related to: https://github.com/openhab/openhab-core/pull/916/#discussion_r305082016

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-07-21 12:24:58 +02:00
Markus Rathgeb fe9b060391 firmware: transfer latest FW don't require a info about previous FW (#884) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:25:22 +02:00
Markus Rathgeb a23cd23a37 map entries of member variables could change between lines (#883) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:24:55 +02:00
Markus Rathgeb a75fbe1e42 Class::getCanonicalName may return null (#882) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-06-20 21:24:20 +02:00
Christoph Weitkamp 7f0d61d6a6 thing: Use constructor injection to simplify lifecycle (#849) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-06-03 13:14:41 +02:00
Christoph Weitkamp eef779e91a Added nullness annotations (#837) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-28 17:56:48 +02:00
Christoph Weitkamp 0d736a700e Use correct profile builder (#831) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-24 19:41:55 +02:00
Christoph Weitkamp 0f74348f51 Factored out 'LocalizedKey' into separate class (#808) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-09 11:57:40 +02:00
Christoph Weitkamp 2a9485bc3b Improvements for 'DefaultSystemChannelTypeProvider' (#807) 
* Use constructor dependency injection
* Added nullness annotations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-09 07:51:56 +02:00
Christoph Weitkamp b5f33d341d Added i18n feature for profiles (#785) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-09 07:50:55 +02:00
Christoph Weitkamp 81423aa22e Separate i18n infrastructure for 'ChannelGroup' (#804) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-05-07 19:32:11 +02:00
Markus Rathgeb eaaf01a5fd use mandatory storage services (#787) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-05-02 21:11:00 +02:00
Christoph Weitkamp 8d5d789371 Changed ordering of annotation and quialifier 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-30 13:22:26 +02:00
Christoph Weitkamp 5888c8b5d6 Added RawButtonToggleRollershutterProfile, RawRockerStopMoveProfile and RawRockerUpDownProfile 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-30 13:22:26 +02:00
Christoph Weitkamp b8de327e15 Added i18n feature for dynamic command descriptions (#771) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-29 19:16:47 +02:00
Christoph Weitkamp 31760bf3a7 Updated xml schema locations to openhab (#769) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-29 19:15:24 +02:00
Christoph Weitkamp 76387f2b79 Changed visibility of lists to allow subclasses to acces them (#770) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-29 19:10:07 +02:00
Christoph Weitkamp 1bbf250d1f Removed deprecated methods (#721) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-28 18:52:16 +02:00
Christoph Weitkamp bc91446ae1 Added i18n feature for dynamic state descriptions (#655) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-26 12:54:40 +02:00
Christoph Weitkamp d0800c902e Added RawButtonTogglePlayerProfile, RawRockerNextPreviousProfile and RawRockerRewindFastforwardProfile (#747) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-26 12:53:16 +02:00
Gaël L'hopital 20ee4b8fe0 Added change and update timestamp profiles (#732) 
* Added change and update timestamp profiles

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
 2019-04-18 12:59:15 +02:00
Christoph Weitkamp 309a1af45f Deprecated method - could be removed because of superflous code (#720) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-15 14:35:48 +02:00
Christoph Weitkamp 0aa7661764 Revert ThingImpl and BridgeImpl changes as the storage uses those implementations (#719) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-14 23:09:09 +02:00
Christoph Weitkamp 48a97c1ac2 Improved thing / bridge performance (#693) 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
 2019-04-10 08:50:04 +02:00
Wouter Born cbb96945f0 Ignore and remove Eclipse project specific settings (#677) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-03-26 13:04:09 +01:00
Markus Rathgeb fdb23778dc improve nullness of events (#657) 
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-03-15 09:10:52 +01:00
Wouter Born 48d873a32b Use openHAB license headers (#632) 
Signed-off-by: Wouter Born <github@maindrain.net>
 2019-03-06 16:10:00 +01:00
Hilbrand Bouwkamp 09e2292a58 Replaces 'Eclipse SmartHome' with 'openHAB' in text (#581) 
Adapted CONTRIBUTING.md file.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
 2019-02-15 10:46:37 +01:00
Hilbrand Bouwkamp d342afbc4e Updated NOTICE files to openHAB (#578) 
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
 2019-02-15 10:46:18 +01:00
Henning Treu 3c8e3efa93 Extend ChannelType by command options (#540) 
This addresses https://github.com/eclipse/smarthome/issues/5099 by adding a command description with command options along with the state description.
Command options will give a hint to UIs about the specific commands a channel provides. Command options could be rendered as a drop down and also represent the current state or rendered as push buttons to simply send a command to the ThingHandler.
The infrstructure basically copies the StateDescription infrastructure with CommandDescriptionProviders and an `DynamicCommandDescriptionProvider` interface for bindings to hook in and provide dynamic command options.

Signed-off-by: Henning Treu <henning.treu@googlemail.com>
 2019-02-12 13:41:01 +00:00
Markus Rathgeb fd95b86b36 centralize the bundle identifier construction 
The ready marker logic is created to hide the real usage. The ready
marker uses an "identifier" that is not specific or limited to bundles.

Currently the bundle symbolic name is used as bundle identifier.
That "convention" needs to be known at several different places.

There should be one method that created an identifier for a bundle and
"no one" needs to care about the implementation details.

Another point is that the bundle symbolic name that has been used is
optional. It may be null e.g. for bundles that has been installed by the
synthetic bundle installer mechanism etc.

The runtime assigns a bundle ID to an installed bundle that remains the
same for the bundle (see JavaDoc). The bundle ID is present all the
time.

The implementation of the "get identifier for bundle" has been choosen
to use the BSN -- if available -- (as before) but fallback to a custom
one using also the bundle ID (to be unique).
So we can provide always a non null identifier for a bundle.
It should be easily to change the identifier creation now if there is
every any need for.

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-02-06 15:56:00 +01:00
Markus Rathgeb 7a1982e785 harden against missing bundle symbolic name (#510) 
Fixes: https://github.com/openhab/openhab-core/issues/508

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-02-01 14:53:38 +01:00
Markus Rathgeb 68c8db8227 add missing no-arg constructors (#509) 
* FirmwareUpdateProgressInfo
* FirmwareStatusInfo
* FirmwareUpdateResultInfo

Fixes: https://github.com/openhab/openhab-core/issues/507

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-02-01 14:24:25 +01:00
Kai Kreuzer 3b6dfbeddb Keep persisted disabled status when thing is removed (#493) 
Also-By: Florian Stolte <fstolte@itemis.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
 2019-01-30 11:37:51 +01:00
Markus Rathgeb fbca7e806f remove project specific JDT settings (#481) 
Done per request by @wborn.
Related to: https://github.com/openhab/openhab-core/pull/476#discussion_r251566034

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-01-29 10:24:39 +01:00
Markus Rathgeb a37cceab67 mavenize openHAB and integrate mavenized ESH repository (#467) 
* mavenize openHAB and integrate mavenized ESH repository

Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
 2019-01-28 13:07:31 +01:00