From f664d756c7db8f66c3f502f480bd9f63b92481d6 Mon Sep 17 00:00:00 2001 From: Wouter Born Date: Sun, 6 Mar 2022 09:19:26 +0100 Subject: [PATCH] Correct GHA build step condition (#2818) Fixes that the wrong build step was made conditional in #2817. It should conditionally add annotations. Signed-off-by: Wouter Born --- .github/workflows/ci-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index ddf5830dc1..5027705d74 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -72,7 +72,7 @@ jobs: -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn - name: Upload Build Log - if: ${{ matrix.java == '11' && always() && ((steps.build.outcome == 'success') || (steps.build.outcome == 'failure')) }} + if: ${{ always() && ((steps.build.outcome == 'success') || (steps.build.outcome == 'failure')) }} uses: actions/upload-artifact@v2 with: name: build-log-java-${{ matrix.java }}-${{ matrix.os }} @@ -86,8 +86,8 @@ jobs: path: target/summary_report.html - name: Report SAT Errors as Annotations + if: ${{ matrix.java == '11' && always() && ((steps.build.outcome == 'success') || (steps.build.outcome == 'failure')) }} uses: ghys/checkstyle-github-action@main - if: ${{ always() && ((steps.build.outcome == 'success') || (steps.build.outcome == 'failure')) }} with: title: CheckStyle Violations path: '**/checkstyle-result.xml'