OpenHAB
/
openhab-core
mirror of https://github.com/openhab/openhab-core.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[DSL] Removed deleted things from internal map (#1058) 

* Applied formatter
* Fixed warnings
* Removed deleted things from internal map

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
pull/1062/head
Christoph Weitkamp 2019-09-30 18:53:47 +02:00 committed by Wouter Born
parent 8b72770bf3
commit e8fcba2ccf
1 changed files with 55 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
bundles/org.openhab.core.model.thing/src/org/eclipse/smarthome/model/thing/internal/GenericThingProvider.xtend
View File

@ -56,7 +56,6 @@ import org.eclipse.smarthome.model.thing.thing.ModelPropertyContainer
import org.eclipse.smarthome.model.thing.thing.ModelThing import org.eclipse.smarthome.model.thing.thing.ModelThing
import org.eclipse.smarthome.model.thing.thing.ThingModel import org.eclipse.smarthome.model.thing.thing.ThingModel
import org.eclipse.xtend.lib.annotations.Data import org.eclipse.xtend.lib.annotations.Data
import org.osgi.framework.FrameworkUtil
import org.osgi.service.component.annotations.Component import org.osgi.service.component.annotations.Component
import org.osgi.service.component.annotations.Reference import org.osgi.service.component.annotations.Reference
import org.slf4j.Logger import org.slf4j.Logger
@ -74,9 +73,8 @@ import org.eclipse.smarthome.core.thing.type.AutoUpdatePolicy
* factory cannot load a thing yet (bug 470368), * factory cannot load a thing yet (bug 470368),
* added delay until ThingTypes are fully loaded * added delay until ThingTypes are fully loaded
* @author Markus Rathgeb - Add locale provider support * @author Markus Rathgeb - Add locale provider support
*
*/ */
@Component(immediate=true, service=ThingProvider) @Component(immediate=true, service=ThingProvider)
class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvider, ModelRepositoryChangeListener, ReadyService.ReadyTracker { class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvider, ModelRepositoryChangeListener, ReadyService.ReadyTracker {
private static final String XML_THING_TYPE = "esh.xmlThingTypes"; private static final String XML_THING_TYPE = "esh.xmlThingTypes";
@ -123,22 +121,22 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
if (model === null) { if (model === null) {
return return
} }
flattenModelThings(model.things).map[ flattenModelThings(model.things).map [
// Get the ThingHandlerFactories // Get the ThingHandlerFactories
val ThingUID thingUID = constructThingUID val ThingUID thingUID = constructThingUID
if (thingUID !== null) { if (thingUID !== null) {
val thingTypeUID = constructThingTypeUID(thingUID) val thingTypeUID = constructThingTypeUID(thingUID)
return thingHandlerFactories.findFirst[ return thingHandlerFactories.findFirst [
supportsThingType(thingTypeUID) supportsThingType(thingTypeUID)
] ]
} else { } else {
// ignore the Thing because its definition is broken // ignore the Thing because its definition is broken
return null return null
} }
]?.filter[ ]?.filter [
// Drop it if there is no ThingHandlerFactory yet which can handle it // Drop it if there is no ThingHandlerFactory yet which can handle it
it !== null it !== null
]?.toSet?.forEach[ ]?.toSet?.forEach [
// Execute for each unique ThingHandlerFactory // Execute for each unique ThingHandlerFactory
createThingsFromModelForThingHandlerFactory(modelName, it) createThingsFromModelForThingHandlerFactory(modelName, it)
] ]
@ -153,7 +151,9 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
val bindingId = new ThingUID(modelThing.bridgeUID).bindingId val bindingId = new ThingUID(modelThing.bridgeUID).bindingId
return new ThingUID(bindingId, modelThing.thingTypeId, modelThing.thingId) return new ThingUID(bindingId, modelThing.thingTypeId, modelThing.thingId)
} else { } else {
logger.warn("Thing {} does not have a bridge so it needs to be defined in full notation like <bindingId>:{}:{}", modelThing.thingTypeId, modelThing.thingTypeId, modelThing.thingId) logger.warn(
"Thing {} does not have a bridge so it needs to be defined in full notation like <bindingId>:{}:{}",
modelThing.thingTypeId, modelThing.thingTypeId, modelThing.thingId)
return null return null
} }
} }
@ -186,10 +186,11 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
]) ])
]) ])
return things + flattenModelThings(things.filter(typeof(ModelBridge)).map(b | b.things).flatten); return things + flattenModelThings(things.filter(typeof(ModelBridge)).map(b|b.things).flatten);
} }
def private void createThing(ModelThing modelThing, Collection<Thing> thingList, ThingHandlerFactory thingHandlerFactory) { def private void createThing(ModelThing modelThing, Collection<Thing> thingList,
ThingHandlerFactory thingHandlerFactory) {
val ThingUID thingUID = getThingUID(modelThing, null) val ThingUID thingUID = getThingUID(modelThing, null)
if (thingUID === null) { if (thingUID === null) {
// ignore the Thing because its definition is broken // ignore the Thing because its definition is broken
@ -213,11 +214,11 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
val thingType = thingTypeUID.thingType val thingType = thingTypeUID.thingType
val label = if (modelThing.label !== null) modelThing.label else thingType?.label val label = if(modelThing.label !== null) modelThing.label else thingType?.label
val location = modelThing.location val location = modelThing.location
val ThingUID bridgeUID = if (modelThing.bridgeUID !== null) new ThingUID(modelThing.bridgeUID) val ThingUID bridgeUID = if(modelThing.bridgeUID !== null) new ThingUID(modelThing.bridgeUID)
val thingFromHandler = getThingFromThingHandlerFactories(thingTypeUID, label, configuration, thingUID, val thingFromHandler = getThingFromThingHandlerFactories(thingTypeUID, label, configuration, thingUID,
bridgeUID, thingHandlerFactory) bridgeUID, thingHandlerFactory)
@ -363,21 +364,18 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
autoUpdatePolicy = resolvedChannelType.autoUpdatePolicy autoUpdatePolicy = resolvedChannelType.autoUpdatePolicy
applyDefaultConfiguration(configuration, resolvedChannelType) applyDefaultConfiguration(configuration, resolvedChannelType)
} else { } else {
logger.error("Channel type {} could not be resolved.", channelTypeUID.asString) logger.error("Channel type {} could not be resolved.", channelTypeUID.asString)
} }
} else { } else {
itemType = it.type itemType = it.type
val kind = if (it.channelKind === null) "State" else it.channelKind val kind = if(it.channelKind === null) "State" else it.channelKind
parsedKind = ChannelKind.parse(kind) parsedKind = ChannelKind.parse(kind)
} }
var channel = ChannelBuilder.create(new ChannelUID(thingUID, id), itemType) var channel = ChannelBuilder.create(new ChannelUID(thingUID, id), itemType).withKind(parsedKind).
.withKind(parsedKind) withConfiguration(configuration).withType(channelTypeUID).withLabel(label).
.withConfiguration(configuration) withAutoUpdatePolicy(autoUpdatePolicy)
.withType(channelTypeUID)
.withLabel(label)
.withAutoUpdatePolicy(autoUpdatePolicy)
channels += channel.build() channels += channel.build()
} }
] ]
@ -386,8 +384,8 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
val channelType = it.channelTypeUID.channelType val channelType = it.channelTypeUID.channelType
if (channelType !== null) { if (channelType !== null) {
channels += channels +=
ChannelBuilder.create(new ChannelUID(thingTypeUID, thingUID, id), channelType.itemType). ChannelBuilder.create(new ChannelUID(thingUID, id), channelType.itemType).withType(
withType(it.channelTypeUID).withAutoUpdatePolicy(channelType.autoUpdatePolicy).build it.channelTypeUID).withAutoUpdatePolicy(channelType.autoUpdatePolicy).build
} else { } else {
logger.warn( logger.warn(
"Could not create channel '{}' for thing '{}', because channel type '{}' could not be found.", "Could not create channel '{}' for thing '{}', because channel type '{}' could not be found.",
@ -403,9 +401,9 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
if (channelType.configDescriptionURI !== null) { if (channelType.configDescriptionURI !== null) {
val configDescription = configDescriptionRegistry.getConfigDescription(channelType.configDescriptionURI) val configDescription = configDescriptionRegistry.getConfigDescription(channelType.configDescriptionURI)
if (configDescription !== null) { if (configDescription !== null) {
configDescription.parameters.filter[ configDescription.parameters.filter [
^default !== null && configuration.get(name) === null ^default !== null && configuration.get(name) === null
].forEach[ ].forEach [
val value = getDefaultValueAsCorrectType(type, ^default) val value = getDefaultValueAsCorrectType(type, ^default)
if (value !== null) { if (value !== null) {
configuration.put(name, value); configuration.put(name, value);
@ -431,12 +429,12 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
return null return null
} }
} catch (NumberFormatException ex) { } catch (NumberFormatException ex) {
logger.warn("Could not parse default value '{}' as type '{}': {}", defaultValue, parameterType, ex.getMessage(), ex); logger.warn("Could not parse default value '{}' as type '{}': {}", defaultValue, parameterType,
ex.getMessage(), ex);
return null; return null;
} }
} }
def private createConfiguration(ModelPropertyContainer propertyContainer) { def private createConfiguration(ModelPropertyContainer propertyContainer) {
val configuration = new Configuration val configuration = new Configuration
propertyContainer.properties.forEach [ propertyContainer.properties.forEach [
@ -490,12 +488,15 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
val newThingUIDs = model.allThingUIDs val newThingUIDs = model.allThingUIDs
val removedThings = oldThings.filter[!newThingUIDs.contains(it.UID)] val removedThings = oldThings.filter[!newThingUIDs.contains(it.UID)]
removedThings.forEach [ removedThings.forEach [
logger.debug("Removing thing '{}' from model '{}'.", it.UID, modelName)
notifyListenersAboutRemovedElement notifyListenersAboutRemovedElement
] ]
createThingsFromModel(modelName) createThingsFromModel(modelName)
thingsMap.get(modelName).removeAll(removedThings)
} }
} }
case org.eclipse.smarthome.model.core.EventType.REMOVED: { case org.eclipse.smarthome.model.core.EventType.REMOVED: {
logger.debug("Removing all things from model '{}'.", modelName)
val things = thingsMap.remove(modelName) ?: newArrayList val things = thingsMap.remove(modelName) ?: newArrayList
things.forEach [ things.forEach [
notifyListenersAboutRemovedElement notifyListenersAboutRemovedElement
@ -511,7 +512,7 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
def private Set<ThingUID> getAllThingUIDs(List<ModelThing> thingList, ThingUID parentUID) { def private Set<ThingUID> getAllThingUIDs(List<ModelThing> thingList, ThingUID parentUID) {
val ret = new HashSet<ThingUID>() val ret = new HashSet<ThingUID>()
thingList.forEach[ thingList.forEach [
val thingUID = getThingUID(it, parentUID) val thingUID = getThingUID(it, parentUID)
ret.add(thingUID) ret.add(thingUID)
if (it instanceof ModelBridge) { if (it instanceof ModelBridge) {
@ -575,7 +576,7 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
def thingHandlerFactoryAdded(ThingHandlerFactory thingHandlerFactory) { def thingHandlerFactoryAdded(ThingHandlerFactory thingHandlerFactory) {
thingsMap.keySet.forEach [ thingsMap.keySet.forEach [
//create things for this specific thingHandlerFactory from the model. // create things for this specific thingHandlerFactory from the model.
createThingsFromModelForThingHandlerFactory(it, thingHandlerFactory) createThingsFromModelForThingHandlerFactory(it, thingHandlerFactory)
] ]
} }
@ -600,9 +601,9 @@ class GenericThingProvider extends AbstractProvider<Thing> implements ThingProvi
} }
def private handleXmlThingTypesLoaded(String bsn) { def private handleXmlThingTypesLoaded(String bsn) {
thingHandlerFactories.filter[ thingHandlerFactories.filter [
getBundleName.equals(bsn) getBundleName.equals(bsn)
].forEach[ thingHandlerFactory | ].forEach [ thingHandlerFactory |
thingHandlerFactory.thingHandlerFactoryAdded thingHandlerFactory.thingHandlerFactoryAdded
] ]
} }