From c02826f882aefc57f900f5ba54cc59c1e0fc9f32 Mon Sep 17 00:00:00 2001 From: Kai Kreuzer Date: Fri, 13 Apr 2018 15:40:31 +0200 Subject: [PATCH] added proper logging in error case (#333) Signed-off-by: Kai Kreuzer --- .../io/sound/internal/EnhancedJavaSoundAudioSink.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bundles/org.openhab.io.sound/src/main/java/org/openhab/io/sound/internal/EnhancedJavaSoundAudioSink.java b/bundles/org.openhab.io.sound/src/main/java/org/openhab/io/sound/internal/EnhancedJavaSoundAudioSink.java index 5d67d072bf..06bbb49e25 100644 --- a/bundles/org.openhab.io.sound/src/main/java/org/openhab/io/sound/internal/EnhancedJavaSoundAudioSink.java +++ b/bundles/org.openhab.io.sound/src/main/java/org/openhab/io/sound/internal/EnhancedJavaSoundAudioSink.java @@ -33,7 +33,7 @@ import javazoom.jl.player.Player; */ public class EnhancedJavaSoundAudioSink extends JavaSoundAudioSink { - private final Logger logger = LoggerFactory.getLogger(EnhancedJavaSoundAudioSink.class); + private static final Logger LOGGER = LoggerFactory.getLogger(EnhancedJavaSoundAudioSink.class); private static AudioFormat mp3 = new AudioFormat(AudioFormat.CONTAINER_NONE, AudioFormat.CODEC_MP3, null, null, null, null); @@ -81,7 +81,7 @@ public class EnhancedJavaSoundAudioSink extends JavaSoundAudioSink { streamPlayer = new Player(audioStream); playInThread(streamPlayer); } catch (JavaLayerException e) { - logger.error("An exception occurred while playing url audio stream : '{}'", e.getMessage()); + LOGGER.error("An exception occurred while playing url audio stream : '{}'", e.getMessage()); } return; } @@ -90,7 +90,7 @@ public class EnhancedJavaSoundAudioSink extends JavaSoundAudioSink { try { playInThread(new Player(audioStream)); } catch (JavaLayerException e) { - logger.error("An exception occurred while playing audio : '{}'", e.getMessage()); + LOGGER.error("An exception occurred while playing audio : '{}'", e.getMessage()); } } } @@ -109,7 +109,7 @@ public class EnhancedJavaSoundAudioSink extends JavaSoundAudioSink { try { player.play(); } catch (Exception e) { - throw new RuntimeException(e.getMessage()); + LOGGER.error("An exception occurred while playing audio : '{}'", e.getMessage()); } finally { player.close(); }