OpenHAB
/
openhab-core
mirror of https://github.com/openhab/openhab-core.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix java.lang.UnsupportedOperationException in StateDescriptionFragmentBuilder (#1405) 

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
pull/1409/head
Christoph Weitkamp 2020-04-05 17:53:48 +02:00 committed by GitHub
parent 86dc92b6c8
commit 259af7aaef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bundles/org.openhab.core/src/main/java/org/openhab/core/types/StateDescriptionFragmentBuilder.java
View File

@ -46,7 +46,7 @@ public class StateDescriptionFragmentBuilder {
this.pattern = legacy.getPattern(); this.pattern = legacy.getPattern();
this.readOnly = Boolean.valueOf(legacy.isReadOnly()); this.readOnly = Boolean.valueOf(legacy.isReadOnly());
if (!legacy.getOptions().isEmpty()) { if (!legacy.getOptions().isEmpty()) {
this.options = legacy.getOptions(); this.options = new ArrayList<>(legacy.getOptions());
} }
} }

5
bundles/org.openhab.core/src/test/java/org/openhab/core/types/StateDescriptionFragmentBuilderTest.java
View File

@ -85,7 +85,8 @@ public class StateDescriptionFragmentBuilderTest {
public void builderWithStateDescription() { public void builderWithStateDescription() {
StateDescription source = new StateDescription(BigDecimal.ZERO, BigDecimal.TEN, BigDecimal.ONE, "pattern", true, StateDescription source = new StateDescription(BigDecimal.ZERO, BigDecimal.TEN, BigDecimal.ONE, "pattern", true,
Collections.singletonList(new StateOption("value", "label"))); Collections.singletonList(new StateOption("value", "label")));
StateDescriptionFragment fragment = StateDescriptionFragmentBuilder.create(source).build(); StateDescriptionFragmentBuilder builder = StateDescriptionFragmentBuilder.create(source);
StateDescriptionFragment fragment = builder.build();
assertThat(fragment.getMinimum(), is(source.getMinimum())); assertThat(fragment.getMinimum(), is(source.getMinimum()));
assertThat(fragment.getMaximum(), is(source.getMaximum())); assertThat(fragment.getMaximum(), is(source.getMaximum()));
@ -93,6 +94,8 @@ public class StateDescriptionFragmentBuilderTest {
assertThat(fragment.getPattern(), is(source.getPattern())); assertThat(fragment.getPattern(), is(source.getPattern()));
assertThat(fragment.isReadOnly(), is(source.isReadOnly())); assertThat(fragment.isReadOnly(), is(source.isReadOnly()));
assertThat(fragment.getOptions(), is(source.getOptions())); assertThat(fragment.getOptions(), is(source.getOptions()));
builder.withOption(new StateOption("NEW value", "NEW label"));
} }
@Test @Test