From b355fa75788135361ab6a3ff7fa9a86bd76fca1b Mon Sep 17 00:00:00 2001 From: mlobstein Date: Thu, 28 Sep 2023 14:38:24 -0500 Subject: [PATCH] Update Play/Pause status to Player channel widget (#15662) Signed-off-by: Michael Lobstein --- bundles/org.openhab.binding.oppo/README.md | 4 +++- .../binding/oppo/internal/handler/OppoHandler.java | 10 ++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/bundles/org.openhab.binding.oppo/README.md b/bundles/org.openhab.binding.oppo/README.md index 4f0c5386b2c..391b9815c83 100644 --- a/bundles/org.openhab.binding.oppo/README.md +++ b/bundles/org.openhab.binding.oppo/README.md @@ -168,7 +168,9 @@ String oppo_remote_button "Remote Button [%s]" { channel="oppo:player:myoppo:rem secondsformat.js: ```javascript -(function(totalSeconds) { +(function(timestamp) { + var totalSeconds = Date.parse(timestamp) / 1000 + if (isNaN(totalSeconds)) { return '-'; } else { diff --git a/bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java b/bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java index e7d5f24f0de..a137f8cb9ef 100644 --- a/bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java +++ b/bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java @@ -324,11 +324,11 @@ public class OppoHandler extends BaseThingHandler implements OppoMessageEventLis } break; default: - logger.warn("Unknown Command {} from channel {}", command, channel); + logger.debug("Unknown command {} from channel {}", command, channel); break; } } catch (OppoException e) { - logger.warn("Command {} from channel {} failed: {}", command, channel, e.getMessage()); + logger.debug("Command {} from channel {} failed: {}", command, channel, e.getMessage()); updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "Sending command failed"); closeConnection(); scheduleReconnectJob(); @@ -492,6 +492,8 @@ public class OppoHandler extends BaseThingHandler implements OppoMessageEventLis updateChannelState(CHANNEL_SUBTITLE_TYPE, UNDEF); } updateChannelState(CHANNEL_PLAY_MODE, playStatus); + updateState(CHANNEL_CONTROL, + PLAY.equals(playStatus) ? PlayPauseType.PLAY : PlayPauseType.PAUSE); // ejecting the disc does not produce a UDT message, so clear disc type manually if (OPEN.equals(playStatus) || NO_DISC.equals(playStatus)) { @@ -716,7 +718,7 @@ public class OppoHandler extends BaseThingHandler implements OppoMessageEventLis } } catch (OppoException | InterruptedException e) { - logger.warn("Polling error: {}", e.getMessage()); + logger.debug("Polling error: {}", e.getMessage()); } // if the last event received was more than 1.25 intervals ago, @@ -835,7 +837,7 @@ public class OppoHandler extends BaseThingHandler implements OppoMessageEventLis connector.sendCommand(OppoCommand.REWIND); } } else { - logger.warn("Unknown control command: {}", command); + logger.debug("Unknown control command: {}", command); } }