From 8623016be835e8428cf7d8b99721f57deb4a5e8b Mon Sep 17 00:00:00 2001 From: Simmon Yau Date: Sat, 1 Mar 2025 11:48:24 -0500 Subject: [PATCH] [ipcamera] Fix bugs in Reolink handler (#18338) * Fix bugs in Reolink handler Signed-off-by: Simmon Yau --- .../org/openhab/binding/ipcamera/internal/ReolinkHandler.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bundles/org.openhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/ReolinkHandler.java b/bundles/org.openhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/ReolinkHandler.java index 00e9757b179..30676c6c1fb 100644 --- a/bundles/org.openhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/ReolinkHandler.java +++ b/bundles/org.openhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/ReolinkHandler.java @@ -323,8 +323,9 @@ public class ReolinkHandler extends ChannelDuplexHandler { } break; default: + // ignore responses from all Setxx commands if (!cutDownURL.startsWith("/cgi-bin/api.cgi?cmd=Set") - || !cutDownURL.startsWith("/api.cgi?cmd=Set")) {// ignore responses from all Setxx commands + && !cutDownURL.startsWith("/api.cgi?cmd=Set")) { ipCameraHandler.logger.warn( "URL {} is not handled currently by the binding, please report this message", cutDownURL); @@ -515,6 +516,7 @@ public class ReolinkHandler extends ChannelDuplexHandler { } else { ipCameraHandler.logger.warn("Unsupported command sent to enableLED channel"); } + break; case CHANNEL_ENABLE_MOTION_ALARM: if (OnOffType.ON.equals(command)) { ipCameraHandler.sendHttpPOST("/api.cgi?cmd=SetMdAlarm" + ipCameraHandler.reolinkAuth);