From 65132c31f6ed47f55f40ecbd3d9604ec7d7b5105 Mon Sep 17 00:00:00 2001 From: Holger Friedrich Date: Wed, 6 Nov 2024 07:56:17 +0100 Subject: [PATCH] [ism8] Improve debug logging (#17705) Signed-off-by: Holger Friedrich --- .../java/org/openhab/binding/ism8/internal/Ism8Handler.java | 4 ++-- .../openhab/binding/ism8/internal/util/Ism8DomainMapTest.java | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/internal/Ism8Handler.java b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/internal/Ism8Handler.java index de614d66834..b36d857440b 100644 --- a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/internal/Ism8Handler.java +++ b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/internal/Ism8Handler.java @@ -177,7 +177,7 @@ public class Ism8Handler extends BaseThingHandler implements IDataPointChangeLis return true; } } else { - logger.debug("Ism8 channel: {} and DataPoint do not have a matching Id: {} vs {}", channel.getUID(), id, + logger.trace("Ism8 channel: {} and DataPoint do not have a matching Id: {} vs {}", channel.getUID(), id, dataPoint.getId()); } } catch (NumberFormatException e) { @@ -193,7 +193,7 @@ public class Ism8Handler extends BaseThingHandler implements IDataPointChangeLis for (Channel channel : getThing().getChannels()) { if (channel.getConfiguration().containsKey(CHANNEL_CONFIG_ID)) { if (updateChannel(channel, dataPoint)) { - break; + return; } } } diff --git a/bundles/org.openhab.binding.ism8/src/test/java/org/openhab/binding/ism8/internal/util/Ism8DomainMapTest.java b/bundles/org.openhab.binding.ism8/src/test/java/org/openhab/binding/ism8/internal/util/Ism8DomainMapTest.java index 311831d3d26..bdc49c2d1e9 100644 --- a/bundles/org.openhab.binding.ism8/src/test/java/org/openhab/binding/ism8/internal/util/Ism8DomainMapTest.java +++ b/bundles/org.openhab.binding.ism8/src/test/java/org/openhab/binding/ism8/internal/util/Ism8DomainMapTest.java @@ -37,8 +37,6 @@ import org.openhab.core.library.unit.Units; import org.openhab.core.types.Command; import org.openhab.core.types.State; import org.openhab.core.util.HexUtils; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * @@ -48,7 +46,6 @@ import org.slf4j.LoggerFactory; @ExtendWith(MockitoExtension.class) @NonNullByDefault public class Ism8DomainMapTest { - private static final Logger LOGGER = LoggerFactory.getLogger(Ism8DomainMap.class); @BeforeEach public void initialize() {