OpenHAB
/
openhab-addons
mirror of https://github.com/openhab/openhab-addons.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[insteon] Fix product data not updating first record (#18296) 

Signed-off-by: Jeremy Setton <jeremy.setton@gmail.com>
4.3.x
Jeremy 2025-02-19 14:13:59 -05:00 committed by Leo Siepel
parent 4022cfab90
commit 1a0f773b0b
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/ProductData.java
View File

@ -159,28 +159,19 @@ public class ProductData {
deviceType = productData.deviceType;
deviceTypeUpdated = productData.deviceType != null;
}
// update remaining properties if defined in given product data
if (productData.productKey != 0) {
productKey = productData.productKey;
}
if (productData.description != null) {
description = productData.description;
}
if (productData.model != null) {
model = productData.model;
}
if (productData.vendor != null) {
vendor = productData.vendor;
}
if (productData.firstRecord != 0) {
firstRecord = productData.firstRecord;
}
// update firmware and hardware if defined in given product data
if (productData.firmware != 0) {
firmware = productData.firmware;
}
if (productData.hardware != 0) {
hardware = productData.hardware;
}
// update remaining properties
productKey = productData.productKey;
description = productData.description;
model = productData.model;
vendor = productData.vendor;
firstRecord = productData.firstRecord;
return deviceTypeUpdated;
}
@ -209,7 +200,7 @@ public class ProductData {
properties.add("deviceType:" + deviceType);
}
if (firstRecord != 0) {
properties.add("firstRecord:" + HexUtils.getHexString(firstRecord));
properties.add("firstRecord:" + HexUtils.getHexString(firstRecord, 4));
}
if (firmware != 0) {
properties.add("firmwareVersion:" + HexUtils.getHexString(firmware));