Commit Graph

8351 Commits (1b60b813ddf1a9f48d8dcfd86ec905357b21da3b)

Author SHA1 Message Date
David Núñez b051457e83 Rewording of newsfragments and exception message. Add some TODOs. 2020-11-07 01:15:47 +01:00
David Núñez 8224c971b2
Merge pull request #2402 from KPrasch/olives
Enroll bare deployment of StakingEscrow 5.5.1
2020-11-06 23:56:33 +01:00
David Núñez 8129835008 Newsfragment for PR 2402 2020-11-06 23:47:32 +01:00
Kieran Prasch 409b08ea24 Enroll bare deployment of StakingEscrow 5.5.1 2020-11-06 23:38:56 +01:00
David Núñez d0334e029c Fix bug in test for local keystore caused by an Ursula too eager to work 2020-11-06 17:12:54 +01:00
David Núñez 35af6a3a07 When mocking the StakingEscrowAgent, handle the special case of commit_to_next_period, which returns a txhash due to the fire_and_forget option
Also, improves type hints related to the special case of commitment TXs, that result in txhashes instead of receipts.
2020-11-06 12:32:51 +01:00
David Núñez 8e30653782 Newsfragments for PR 2425 and closure of issues 2406 and 2421 2020-11-06 12:19:34 +01:00
David Núñez 4a263940ba Another example of using a class variable as default that doesn't work as expected with inheritance
This is probably why we usually had a hard-time setting the free_gas_strategy in the past.
Anyway, it also closes #2421 as now BlockchainInterface.gas_strategy always has a value; previously it was possible to pass None in the constructor (e.g. if the config file had an explicit "null" value).
2020-11-06 12:19:34 +01:00
David Núñez 7951c668ba We were forgetting to return True sometimes when checking consistency of the commitment tracker 2020-11-06 12:19:34 +01:00
David Núñez 2acb8f642e Add references to issue with initial commitment on make_decentralized_ursulas utility. See 2424 2020-11-06 12:19:34 +01:00
David Núñez 6d5580020a Check current on-chain period before considering pending transactions
Otherwise, it's possible to fire a replacement TX unnecessarily
2020-11-06 12:19:34 +01:00
David Núñez 0c23a40890 Improve logging of replacement commitment TXs logic 2020-11-06 12:19:34 +01:00
David Núñez 50366c2fde Allow to set the gas strategy at the interface layer 2020-11-06 12:19:34 +01:00
David Núñez 3b70b06a8a Support for user-provided gas price via a fixed-price gas strategy 2020-11-06 12:19:34 +01:00
David Núñez 7f45dedecf
Merge pull request #2412 from cygnusv/llaves
Use NuCypher Logger instead of Twisted Logger. Closes #2404
2020-11-06 12:17:14 +01:00
David Núñez 56fd5cf7be Adapt format of newfragment to usual style 2020-11-06 11:47:24 +01:00
Justin Holmes 579dc0819f
Merge pull request #2423 from jMyles/domains
Moving domain check into FleetSensor.
2020-11-04 14:35:36 -07:00
jMyles ef29bec8e7 Neatening formatting, also pursuant to RFC. 2020-11-04 14:04:32 -07:00
jMyles c015ec0ab7 Nixing this silly block pursuant to RFC. 2020-11-04 14:04:11 -07:00
jMyles 66959a9e72 Newsfragment update. 2020-11-03 19:30:22 -07:00
jMyles 158e0ee62b Ursula needs an explicit domain in this test in order for Bob to be able to retrieve. 2020-11-03 19:11:37 -07:00
jMyles 9e009805fd Ursulas and NodeSprouts now share a common API, with domain as str. 2020-11-03 18:13:15 -07:00
jMyles d1313581ef Even when including nodes as seednode metadata, the domain is checked before remembering the resulting Sprout. 2020-11-03 18:13:15 -07:00
jMyles 0aa33c3f1e Can't just plunk federated_ursulas into known_nodes anymore if they aren't on the same domain. 2020-11-03 18:13:15 -07:00
jMyles 8bfa31b11b Test showing that the cross-domain pollution via POST is no longer possible. 2020-11-03 18:13:15 -07:00
jMyles 6cb3feae86 Making this test way better now that domains are tightened up> 2020-11-03 18:13:15 -07:00
jMyles 7b7a85ed26 Final low-level domain check before adding node to fleet. 2020-11-03 18:13:15 -07:00
jMyles c173ba22e0 Properly decoding a domain from a Sprout in order to be consistent with Ursula API.' 2020-11-03 18:13:15 -07:00
jMyles c4786f551a No longer are there 'serving' domains and 'learning' domains. Everybody just has a domain. 2020-11-03 18:13:15 -07:00
jMyles c9118d1f02 FleetSensor is now domain-aware. 2020-11-03 18:13:08 -07:00
damon c 2eb6d1b986
Merge pull request #2415 from derekpierre/towncrier-doc
Update newsfragment documentation
2020-11-03 14:04:01 -08:00
David Núñez d917a17070
Merge pull request #2422 from vepkenez/zombie-on-error
For people who enjoy reliable performance
2020-11-03 23:01:58 +01:00
derekpierre c2aad152ef Additional clarification about optional use of issue newsfragment files. 2020-11-03 14:49:57 -05:00
damon c 0f89c391f9
Update newsfragments/2422.bugfix.rst
Co-authored-by: K Prasch <kieranprasch@gmail.com>
2020-11-03 09:17:45 -08:00
damon e07af3df19 add release notes 2020-11-03 08:54:32 -08:00
damon 71910fff74 don't abort on error please 2020-11-03 08:52:24 -08:00
David Núñez e4ef0b32a3
Merge pull request #2395 from cygnusv/minfee
Fix for nucypher stake set-min-rate
2020-11-03 15:48:27 +01:00
David Núñez edbdf4b415 Newsfragments for PR 2395 and closure of issue 2390 2020-11-03 13:20:01 +01:00
David Núñez 90c39c53ce Tone-down learning logging even more (see #1712) 2020-11-03 13:09:57 +01:00
David Núñez 0b95999838 Fix missing space in exception message for Trezor 2020-11-03 13:09:57 +01:00
David Núñez 0b2dd001ba Correct problems when setting the min fee rate. Fix #2390
Also, simplifies usage by expressing rates in GWEI
2020-11-03 12:10:59 +01:00
David Núñez 9724820420 Remove repeated message in nucypher ursula config 2020-11-03 12:10:59 +01:00
David Núñez 03b7545a92 Additional test cases for loggers 2020-11-03 12:03:09 +01:00
David Núñez 7ad071ec53
Update newsfragments/2412.bugfix.rst
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
2020-11-02 17:42:21 +01:00
derekpierre 020f3ea837 Add newsfragment for README change. 2020-10-30 17:13:06 -04:00
derekpierre 43b1aaace3 Update newsfragments README document to indicate that PR number should be used for naming files. 2020-10-30 17:09:10 -04:00
David Núñez 8df01c4fb2 Add newsfragment for the fixes in this PR wrt to NuCypher Logger 2020-10-30 22:06:56 +01:00
David Núñez 67596a8aec Change NuCypherLogger behavior to always escape curly braces.
The rationale is that it's unclear how to justify the previous behavior with some edge cases like `{{}`, which was `{}`.
Also unit tests are improved even further.
2020-10-30 21:53:14 +01:00
David Núñez 04239ba532 Remove leftover imports of Twisted Logger 2020-10-30 20:55:56 +01:00
David Núñez 1d750af1f9 Even more detailed tests for NuCypher logger: now with JSON observer 2020-10-30 20:55:56 +01:00