From bf8be2443506b5139341df4194de5f2cf74ea925 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=BA=C3=B1ez?= Date: Wed, 16 Dec 2020 01:52:40 +0100 Subject: [PATCH] Iterate on the PR template based on team's feedback --- .github/PULL_REQUEST_TEMPLATE.md | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b1a8344f3..851b17b11 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,27 @@ -**Type of PR**: Bugfix / Feature / Docs / Other +**Type of PR:** +- [ ] Bugfix +- [ ] Feature +- [ ] Documentation +- [ ] Other -**Required reviews**: 1 / 2 / 3 +**Required reviews:** +- [ ] 1 +- [ ] 2 +- [X] 3 -**What does this PR do? Why is it needed?** +**What this does:** +> High-level idea of the changes introduced in this PR. +> List relevant API changes (if any). -> Try to answer both questions, when possible. -> The second one is often not obvious and can help the team to prioritize. +**Issues fixed/closed:** -**Which issues(s) does this PR fix?** +> - Fixes #... -> Fixes #... +**Why it's needed:** +> Explain how this PR fits in the greater context of the NuCypher Network, +> so it's justified why this PR (and reviewing it) is necessary. + +**Does this PR address a `nucypher/productdev` issue?** Yes/No **Notes for reviewers:**