Nucypher
/
nucypher
mirror of https://github.com/nucypher/nucypher.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove commented out lines in tests concerning unsupported chain ids. Condition objects don't have any concept of TACo domains and therefore have no insight into which chains are supported. Now that `lynx` supports "any" EVM chain this has become more evident and those test cases are not longer valid.

pull/3569/head
derekpierre 2024-12-12 12:39:33 -05:00
parent 8d1a68b7b6
commit acf59fdd9f
No known key found for this signature in database
2 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/unit/conditions/test_rpc_condition.py
View File

@ -47,15 +47,6 @@ def test_invalid_rpc_condition():
parameters=["0xaDD9D957170dF6F33982001E4c22eCCdd5539118"],
)
# # unsupported chain id
# with pytest.raises(InvalidCondition, match="90210 is not a permitted blockchain"):
# _ = RPCCondition(
# method="eth_getBalance",
# chain=90210, # Beverly Hills Chain :)
# return_value_test=ReturnValueTest("==", 0),
# parameters=["0xaDD9D957170dF6F33982001E4c22eCCdd5539118"],
# )
# invalid chain type provided
with pytest.raises(ValueError, match="invalid literal for int"):
_ = RPCCondition(
@ -105,12 +96,6 @@ def test_rpc_condition_schema_validation(rpc_condition):
condition_dict["chain"] = str(TESTERCHAIN_CHAIN_ID)
RPCCondition.from_dict(condition_dict)
# with pytest.raises(InvalidConditionLingo):
# # chain id not a permitted chain
# condition_dict = rpc_condition.to_dict()
# condition_dict["chain"] = 90210 # Beverly Hills Chain :)
# RPCCondition.from_dict(condition_dict)
def test_rpc_condition_repr(rpc_condition):
rpc_condition_str = f"{rpc_condition}"

14
tests/unit/conditions/test_time_condition.py
View File

@ -27,14 +27,6 @@ def test_invalid_time_condition():
method="time_after_time",
)
# chain id not permitted
# with pytest.raises(InvalidCondition):
# _ = TimeCondition(
# return_value_test=ReturnValueTest(">", 0),
# chain=90210, # Beverly Hills Chain :)
# method=TimeRPCCall.METHOD,
# )
def test_time_condition_schema_validation(time_condition):
condition_dict = time_condition.to_dict()
@ -70,12 +62,6 @@ def test_time_condition_schema_validation(time_condition):
condition_dict["chain"] = str(TESTERCHAIN_CHAIN_ID)
TimeCondition.from_dict(condition_dict)
# with pytest.raises(InvalidConditionLingo):
# # chain id not a permitted chain
# condition_dict = time_condition.to_dict()
# condition_dict["chain"] = 90210 # Beverly Hills Chain :)
# TimeCondition.from_dict(condition_dict)
@pytest.mark.parametrize(
"invalid_value", ["0x123456", 10.15, [1], [1, 2, 3], [True, [1, 2], "0x0"]]