Don't ship blockchain_bob with known_nodes; he can use his domain hardcoded nodes. Also, don't start his learning loop after the fact. This caused this test to pass even when he was unable to actually find the nodes in join_policy.

pull/2128/head
jMyles 2020-07-09 20:42:27 -07:00
parent a7303702ab
commit 86398eb43a
4 changed files with 3 additions and 5 deletions

View File

@ -555,7 +555,6 @@ def test_collect_rewards_integration(click_runner,
assert arrangement.ursula == ursula
# Bob learns about the new staker and joins the policy
blockchain_bob.start_learning_loop()
blockchain_bob.remember_node(node=ursula)
blockchain_bob.join_policy(random_policy_label, bytes(blockchain_alice.stamp))

View File

@ -211,7 +211,7 @@ def bob_blockchain_test_config(blockchain_ursulas, testerchain, test_registry):
provider_uri=TEST_PROVIDER_URI,
test_registry=test_registry,
checksum_address=testerchain.bob_account,
known_nodes=blockchain_ursulas)
)
yield config
config.cleanup()

View File

@ -20,7 +20,6 @@ from unittest.mock import patch
from nucypher.network.server import make_rest_app
from tests.mock.serials import good_serials
from tests.utils.ursula import MOCK_KNOWN_URSULAS_CACHE
from umbral.config import default_params
from umbral.keys import UmbralPublicKey
from umbral.signing import Signature

View File

@ -93,9 +93,9 @@ class MockRestMiddleware(RestMiddleware):
class TEACHER_NODES:
@classmethod
def get(_cls, item, default):
def get(_cls, item, _default):
if item is TEMPORARY_DOMAIN:
nodes = tuple(u.rest_url() for u in MOCK_KNOWN_URSULAS_CACHE.values())
nodes = tuple(u.rest_url() for u in MOCK_KNOWN_URSULAS_CACHE.values())[0:2]
else:
nodes = tuple()
return nodes