From 442c9a7c3057ce6b26d54be05a523fda61b39b43 Mon Sep 17 00:00:00 2001 From: Kieran Prasch Date: Mon, 8 Jun 2020 14:50:57 -0700 Subject: [PATCH] Respond to RFCs in PR #2078 --- .../blockchain/clients/test_geth_integration.py | 8 ++++---- tests/markers.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/acceptance/blockchain/clients/test_geth_integration.py b/tests/acceptance/blockchain/clients/test_geth_integration.py index 8c8d76228..57ff8c2e6 100644 --- a/tests/acceptance/blockchain/clients/test_geth_integration.py +++ b/tests/acceptance/blockchain/clients/test_geth_integration.py @@ -27,10 +27,10 @@ from nucypher.blockchain.eth.interfaces import ( ) from nucypher.crypto.api import verify_eip_191 from tests.constants import INSECURE_DEVELOPMENT_PASSWORD -from tests.markers import skip_circleci +from tests.markers import skip_on_circleci -@skip_circleci +@skip_on_circleci def test_geth_EIP_191_client_signature_integration(instant_geth_dev_node): # Start a geth process @@ -47,7 +47,7 @@ def test_geth_EIP_191_client_signature_integration(instant_geth_dev_node): assert is_valid -@skip_circleci +@skip_on_circleci def test_geth_create_new_account(instant_geth_dev_node): blockchain = BlockchainInterface(provider_process=instant_geth_dev_node, poa=True) blockchain.connect() @@ -55,7 +55,7 @@ def test_geth_create_new_account(instant_geth_dev_node): assert is_checksum_address(new_account) -@skip_circleci +@skip_on_circleci def test_geth_deployment_integration(instant_geth_dev_node, test_registry): blockchain = BlockchainDeployerInterface(provider_process=instant_geth_dev_node, poa=True) # always poa here. BlockchainInterfaceFactory.register_interface(interface=blockchain) diff --git a/tests/markers.py b/tests/markers.py index fcf7f0201..9c319ac3a 100644 --- a/tests/markers.py +++ b/tests/markers.py @@ -20,4 +20,4 @@ import pytest circleci_only = pytest.mark.skipif(condition=('CIRCLECI' not in os.environ), reason='Only run on CircleCI') -skip_circleci = pytest.mark.skipif(condition=('CIRCLECI' in os.environ), reason='Only run on CircleCI') +skip_on_circleci = pytest.mark.skipif(condition=('CIRCLECI' in os.environ), reason='Do not run on CircleCI')