Nucypher
/
nucypher
mirror of https://github.com/nucypher/nucypher.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use json parameter instead of data when using requests.post; also simplifies testing.

pull/3573/head
derekpierre 2024-12-17 09:04:29 -05:00
parent 91779df1fb
commit 258f5cd3ae
No known key found for this signature in database
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nucypher/policy/conditions/json/base.py
View File

@ -1,4 +1,3 @@
import json
from abc import ABC
from enum import Enum
from http import HTTPStatus
@ -72,7 +71,7 @@ class JsonRequestCall(ExecutionCall, ABC):
# POST
response = requests.post(
resolved_endpoint,
data=json.dumps(resolved_parameters),
json=resolved_parameters,
timeout=self.timeout,
headers=headers,
)

8
tests/unit/conditions/test_json_rpc_condition.py
View File

@ -81,7 +81,7 @@ def test_json_rpc_condition_verify(mocker):
assert result == 19
assert mocked_method.call_count == 1
assert json.loads(mocked_method.call_args.kwargs["data"]) == {
assert mocked_method.call_args.kwargs["json"] == {
"jsonrpc": "2.0",
"id": 1,
"method": condition.method,
@ -108,7 +108,7 @@ def test_json_rpc_condition_verify_params_as_dict(mocker):
assert result == 19
assert mocked_method.call_count == 1
assert json.loads(mocked_method.call_args.kwargs["data"]) == {
assert mocked_method.call_args.kwargs["json"] == {
"jsonrpc": "2.0",
"id": 1,
"method": condition.method,
@ -176,7 +176,7 @@ def test_json_rpc_condition_evaluation_with_auth_token(mocker):
assert result == 19
assert mocked_method.call_count == 1
assert json.loads(mocked_method.call_args.kwargs["data"]) == {
assert mocked_method.call_args.kwargs["json"] == {
"jsonrpc": "2.0",
"id": 1,
"method": condition.method,
@ -222,7 +222,7 @@ def test_json_rpc_condition_evaluation_with_various_context_variables(mocker):
call_args = mocked_post.call_args
assert call_args.args == (f"https://math.example.com/{context[':version']}/simple",)
assert call_args.kwargs["headers"]["Authorization"] == f"Bearer {auth_token}"
assert json.loads(call_args.kwargs["data"]) == {
assert call_args.kwargs["json"] == {
"jsonrpc": "2.0",
"id": 1,
"method": context[":methodContextVar"],