Missing TODOs

pull/1655/head
David Núñez 2020-02-04 20:48:48 +01:00 committed by Kieran R. Prasch
parent 93eae3e248
commit 12192c63e9
4 changed files with 7 additions and 3 deletions

View File

@ -644,7 +644,7 @@ class PolicyManagerAgent(EthereumContractAgent):
node_addresses)
receipt = self.blockchain.send_transaction(contract_function=contract_function,
payload=payload,
sender_address=author_address)
sender_address=author_address) # TODO: Gas management - #842
return receipt
def fetch_policy(self, policy_id: str) -> list:

View File

@ -1017,6 +1017,7 @@ class Teacher:
This is the most mature form, so we do nothing.
"""
# TODO: Unused method. Remove?
def save_cert_for_this_stranger_node(stranger, certificate):
return stranger._cert_store_function(certificate)

View File

@ -343,6 +343,9 @@ class Policy(ABC):
Assign kfrags to ursulas_on_network, and distribute them via REST,
populating enacted_arrangements
"""
# TODO: #121 - Consider tweaking the order of the enactment steps:
# first create the policy on chain and then send the kfrags together with the TX receipt
for arrangement in self.__assign_kfrags():
policy_message_kit = arrangement.encrypt_payload_for_ursula()
@ -626,7 +629,7 @@ class BlockchainPolicy(Policy):
prearranged_ursulas = list(a.ursula.checksum_address for a in self._accepted_arrangements)
# Transact
# Transact # TODO: Move this logic to BlockchainPolicyActor
receipt = self.author.policy_agent.create_policy(
policy_id=self.hrac()[:16], # bytes16 _policyID
author_address=self.author.checksum_address,

View File

@ -58,7 +58,7 @@ class MockPolicy(Policy):
ursula=ursula,
arrangement=arrangement)
# TODO: Remove. Seems unused
class MockPolicyCreation:
"""
Simple mock logic to avoid repeated hammering of blockchain policies.