mirror of https://github.com/node-red/node-red.git
Apply suggestions from code review
parent
c771b175b1
commit
aaa4e60d58
|
@ -23,7 +23,7 @@ module.exports = function(RED) {
|
||||||
this.scope = n.scope;
|
this.scope = n.scope;
|
||||||
|
|
||||||
// auto-filter out any directly connected nodes to avoid simple loopback
|
// auto-filter out any directly connected nodes to avoid simple loopback
|
||||||
const w = this.wires.flat().toString();
|
const w = this.wires.flat();
|
||||||
for (let i=0; i < this.scope.length; i++) {
|
for (let i=0; i < this.scope.length; i++) {
|
||||||
if (w.includes(this.scope[i])) {
|
if (w.includes(this.scope[i])) {
|
||||||
this.scope.splice(i, 1);
|
this.scope.splice(i, 1);
|
||||||
|
|
|
@ -23,7 +23,7 @@ module.exports = function(RED) {
|
||||||
this.scope = n.scope;
|
this.scope = n.scope;
|
||||||
|
|
||||||
// auto-filter out any directly connected nodes to avoid simple loopback
|
// auto-filter out any directly connected nodes to avoid simple loopback
|
||||||
const w = this.wires.flat().toString();
|
const w = this.wires.flat();
|
||||||
for (let i=0; i < this.scope.length; i++) {
|
for (let i=0; i < this.scope.length; i++) {
|
||||||
if (w.includes(this.scope[i])) {
|
if (w.includes(this.scope[i])) {
|
||||||
this.scope.splice(i, 1);
|
this.scope.splice(i, 1);
|
||||||
|
|
|
@ -1,18 +1,3 @@
|
||||||
/**
|
|
||||||
* Copyright JS Foundation and other contributors, http://js.foundation
|
|
||||||
*
|
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
||||||
* you may not use this file except in compliance with the License.
|
|
||||||
* You may obtain a copy of the License at
|
|
||||||
*
|
|
||||||
* http://www.apache.org/licenses/LICENSE-2.0
|
|
||||||
*
|
|
||||||
* Unless required by applicable law or agreed to in writing, software
|
|
||||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
||||||
* See the License for the specific language governing permissions and
|
|
||||||
* limitations under the License.
|
|
||||||
**/
|
|
||||||
|
|
||||||
var should = require("should");
|
var should = require("should");
|
||||||
var catchNode = require("nr-test-utils").require("@node-red/nodes/core/common/24-complete.js");
|
var catchNode = require("nr-test-utils").require("@node-red/nodes/core/common/24-complete.js");
|
||||||
|
|
Loading…
Reference in New Issue